Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 10 Nov 2023 08:12:07 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Euler Taveira <euler@eulerto.com>, pgsql-hackers@lists.postgresql.org,
	Amit Kapila <amit.kapila16@gmail.com>,
	Andres Freund <andres@anarazel.de>
Subject: Re: speed up a logical replica setup
Message-ID: <ZU1nR5KMZtSTEQDf@paquier.xyz>
References: <5ac50071-f2ed-4ace-a8fd-b892cffd33eb@www.fastmail.com>
 <4710d895-689a-4ae6-b8e3-344286dbf970@app.fastmail.com>
 <da078f11-d2de-420e-9611-f3b7d4dadd9a@eisentraut.org>
 <ZUrEclC-uZV-rGd2@paquier.xyz>
 <96e3b739-d63d-4d35-90a3-7869465b7167@eisentraut.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="yJ+Ta6cLeCrBxJ6Z"
Content-Disposition: inline
In-Reply-To: <96e3b739-d63d-4d35-90a3-7869465b7167@eisentraut.org>
Archived-At: <https://www.postgresql.org/message-id/ZU1nR5KMZtSTEQDf%40paquier.xyz>
Precedence: bulk


--yJ+Ta6cLeCrBxJ6Z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 09, 2023 at 03:41:53PM +0100, Peter Eisentraut wrote:
> On 08.11.23 00:12, Michael Paquier wrote:
>> - Should the subdirectory pg_basebackup be renamed into something more
>> generic at this point?  All these things are frontend tools that deal
>> in some way with the replication protocol to do their work.  Say
>> a replication_tools?
>=20
> Seems like unnecessary churn.  Nobody has complained about any of the oth=
er
> tools in there.

Not sure.  We rename things across releases in the tree from time to
time, and here that's straight-forward.

>> - And if it would be better to refactor some of the code generic to
>> all these streaming tools to fe_utils.  What makes streamutil.h a bit
>> less pluggable are all its extern variables to control the connection,
>> but perhaps that can be an advantage, as well, in some cases.
>=20
> Does anyone outside of pg_basebackup + existing friends + new friend need
> that?  Seems like extra complications.

Actually, yes, I've used these utility routines in some past work, and
having the wrapper routines able to run the replication commands in
fe_utils would have been nicer than having to link to a source tree.
--
Michael

--yJ+Ta6cLeCrBxJ6Z
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmVNZ0cACgkQnvQgOdby
QH2iDg/+NCsrtGzzib+lYGYk60PkK/IxfF3lmC7I3cLxyN2f5OhlWvihDzCJG9r5
Tn/yymN5jKbIbChoFN53+5Nd0gtd1doJCNERe272X22qFVpITR8s3wt+JUFrs+8y
TyP1tVe5X5edrb+XjA6U/luksY4kv2qDTS4rJISZOxXvqf+Nib4Xf1mOrnguEF99
y5evYDadwfC/56L1CcaYXi+oz7dkdYp2xcIVs26M+s5TMHTq3i2bXdYm1AFOtL5T
Dicq7npoTUCkInKjLSYfeeujm2u+Jj3zOPUIrSQQ/+QYgElhkYuuiztlpLw5rZlO
pT+cesAtuRir0vOdPdd45dqkUFuOJRrMJ7mqsD6VnDN8yldO/BXZamowlXux1PVe
i4yAlvny4Q3YFUAC94l2EN2tDHuMBL7rv/BIGYjWDe2dPKT8Uoxv4lzGG3ZV1z+4
nrSKHwx52FagJ0MKMLiHmUnjicv1d/Ik/OcweVNSKXvAl5iXrvsczi8Lh5LmGoNa
92SBqkutfpfo5PvDJNk26xM/mwhFJFlNJtqPsDNG/77UQRr03MGLuDJV1iivQuoF
kPCkn4pyYYzpNaccjLqH1sAUMAdEtnw1MkmPwvfl0dIvcXqhi4mMzibOctX3Fsqh
Af6PsoF1K1g8szra0Qbbjuuz+L0UAphjKbvVWHbqFwztdiRVRag=
=NLpy
-----END PGP SIGNATURE-----

--yJ+Ta6cLeCrBxJ6Z--