Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1r1Vy5-00BdQZ-5E
	for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Nov 2023 18:10:57 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1r1Vy3-004fdo-Bd
	for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Nov 2023 18:10:55 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <cb@df7cb.de>)
	id 1r1Vy3-004fdg-1o
	for pgsql-hackers@lists.postgresql.org; Fri, 10 Nov 2023 18:10:55 +0000
Received: from feynman.df7cb.de ([195.49.152.168])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <cb@df7cb.de>)
	id 1r1Vxz-004wRC-PT
	for pgsql-hackers@lists.postgresql.org; Fri, 10 Nov 2023 18:10:53 +0000
Received: from msg.df7cb.de (unknown [IPv6:2a02:908:1482:3660:b7d0:f584:a987:bc23])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384)
	(Client did not present a certificate)
	by feynman.df7cb.de (Postfix) with ESMTPSA id 4SRn1k09tKz3FvY;
	Fri, 10 Nov 2023 19:10:50 +0100 (CET)
Date: Fri, 10 Nov 2023 19:10:49 +0100
From: Christoph Berg <myon@debian.org>
To: Thomas Munro <tmunro@postgresql.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Don't trust unvalidated xl_tot_len.
Message-ID: <ZU5yKecW5yMKKhtp@msg.df7cb.de>
References: <E1qjozv-005NY4-Rr@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1qjozv-005NY4-Rr@gemulon.postgresql.org>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/ZU5yKecW5yMKKhtp%40msg.df7cb.de>
Precedence: bulk

Re: Thomas Munro
> Don't trust unvalidated xl_tot_len.

> src/test/recovery/t/039_end_of_wal.pl   | 460 ++++++++++++++++++++++++++++++++

I haven't investigated the details yet, and it's not affecting the
builds on apt.postgresql.org, but the Debian amd64 and i386 regression
tests just failed this test on PG13 (11 and 15 are ok):

t/039_end_of_wal.pl ..................
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run
Test Summary Report
-------------------
t/039_end_of_wal.pl                (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
Files=26, Tests=254, 105 wallclock secs ( 0.10 usr  0.02 sys + 19.58 cusr 11.02 csys = 30.72 CPU)
Result: FAIL
make[2]: *** [Makefile:23: check] Error 1

https://salsa.debian.org/postgresql/postgresql/-/jobs/4910354
https://salsa.debian.org/postgresql/postgresql/-/jobs/4910355

Christoph