Date: Tue, 31 Oct 2023 08:51:48 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] postgresql.conf.sample comment alignment.
Message-ID: <ZUD4ZFS4dHlzi9_N@momjian.us>
References: <2235495.1659398604@sss.pgh.pa.us>
 <20220803105804.s6obhhp4qttl4mav@alvherre.pgsql>
 <YuscR8ogXqUd4ijV@paquier.xyz>
 <CAHut+Pv0CCx0M+pg=GfapBXxUnukiUFUsO7uS2WU6x-kd1nN9A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHut+Pv0CCx0M+pg=GfapBXxUnukiUFUsO7uS2WU6x-kd1nN9A@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZUD4ZFS4dHlzi9_N%40momjian.us>
Precedence: bulk

On Thu, Aug  4, 2022 at 12:42:38PM +1000, Peter Smith wrote:
> On Thu, Aug 4, 2022 at 11:09 AM Michael Paquier <michael@paquier.xyz> wrote:
> >
> > On Wed, Aug 03, 2022 at 12:58:04PM +0200, Alvaro Herrera wrote:
> > > On 2022-Aug-01, Tom Lane wrote:
> > >> One idea for avoiding confusion is to legislate that we won't
> > >> use tabs at all in this file (which we could enforce via
> > >> .gitattributes, I think).
> > >
> > > +1.
> >
> > That's not the first time this 4- or 8-character tab issue is popping
> > up around here, so enforcing spaces and having a rule sounds like a
> > good idea at the end.
> >
> 
> Well, it was only assumed that I had probably confused 4- 8- tabs, but
> I don't think I did, so the tabbing issue did not really "pop up"
> here.
> 
> e.g. you can see some of the existing alignments I'd suggested
> modifying here [1]
> - #shared_preload_libraries = '' # (change requires restart)
> - #idle_in_transaction_session_timeout = 0 # in milliseconds, 0 is
> disable <- (moved comments of the neighbours to keep them all aligned)
> - etc.
> 
> I'm not saying replacing the tabs with spaces isn't a good idea - I
> also agree probably it is, but that's a different problem to the
> alignments I was trying to correct with the patch

Patch applied to master.  Perhaps someday we will adjust tabs, but for
now, this is an improvements.  I made a few small adjustments myself.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.