Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 1 Nov 2023 07:54:46 +0900
From: Michael Paquier <michael@paquier.xyz>
To: torikoshia <torikoshia@oss.nttdata.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	bharath.rupireddyforpostgres@gmail.com,
	pgsql-hackers@postgresql.org
Subject: Re: Add new option 'all' to pg_stat_reset_shared()
Message-ID: <ZUGFttiY_DgwUk2s@paquier.xyz>
References: <4291a55137ddda77cf7cc5f46e846daf@oss.nttdata.com>
 <20231030.171713.274529745163206826.horikyota.ntt@gmail.com>
 <CALj2ACVp4K9HqF0Z+k7=Fwg1N5y=74n89T8J7c2cGXFOCquRUA@mail.gmail.com>
 <20231031.115931.1009045759469844714.horikyota.ntt@gmail.com>
 <bef9580768ec5e59cae0bd0dbd6e9452@oss.nttdata.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="jeQQ8Dovcf6Uf7LK"
Content-Disposition: inline
In-Reply-To: <bef9580768ec5e59cae0bd0dbd6e9452@oss.nttdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZUGFttiY_DgwUk2s%40paquier.xyz>
Precedence: bulk


--jeQQ8Dovcf6Uf7LK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 31, 2023 at 04:26:18PM +0900, torikoshia wrote:
> Yes, calling pg_stat_reset_shared() for all stats types can do what I wan=
ted
> to do.
> But calling it with 6 different parameters seems tiresome and I thought it
> would be convenient to have a parameter to delete all cluster-wide
> statistics at once.
>=20
> I may be wrong, but I imagine that it's more common to want to delete all=
 of
> the statistics for an entire cluster rather than just a portion of it.

If more flexibility is wanted in this function, could it be an option
to consider a flavor like pg_stat_reset_shared(text[]), where it is
possible to specify a list of shared stats types to reset?  Perhaps
there are no real use cases for it, just wanted to mention it anyway
regarding the fact that it could have benefits to refactor this code
to use a bitwise operator for its internals with bit flags for each
type.
--
Michael

--jeQQ8Dovcf6Uf7LK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmVBhbYACgkQnvQgOdby
QH0IXA//fjatBtQ5qGnGUF8mXZMrzaKXgGFPm+jxkKpSRVQir4CLc+ZnRpxuiNTH
rjzIcltp+atibMCa2mrqL19sZWnsbsxPLeiEVrIsrIiFoGuZ5UJrhfEovRV78vgU
B97NZjs6mcQpabfiQ2IXT8PujZoScMKppVdYNKTRykW4kLOmWW81SO5OWFGEXLlT
5NDz1abY0D0CvS0KdiaJ/ADXAo201UJT4KWUfL6/w7E8hfQJwTq88Hu9qjl7ykUH
02vigFcWT2CXLFgg5slitRIqoxuxTwnVe7PDaQSamBdkW1OGik6TQTH9JO2NTbvL
OkfrsuWZHHeVTF3jHGLEwZhPXPy4ZOsvXYiHlDK1euVYxRGvNvxfdCQKxxD/lr2W
Iiks9N/Dkn4omV6sIq9jXCGiZMQvUJMpRRtGpF1W7ZWlvshrhcPNBb/5q/8AAu27
hxwzd0aL0I2P06/BPxZSKFCY1fhsCAh3CLPRc4w/zny+4ndJPt13cdvd7RB11x2Q
bOxuwZz1xSyR+c53OtVBy3TSG9U/B/FbGLZaEPoTV0m8LLYRzWvQzkWLGM7yNxMe
KNOA/PIn1se4gZdBAfXofdKigUa/z+V1xNVO04t9JHmyChIjGBaM/um1HL6SbzY0
S8xnHT/PtYtjQtIl7wB3Wx6AdnJ2IraWw1zTTRmTQg0FfyFwem8=
=QTEG
-----END PGP SIGNATURE-----

--jeQQ8Dovcf6Uf7LK--