public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bruce Momjian <[email protected]>
To: Tom Lane <[email protected]>
Cc: Yugo NAGATA <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: [email protected]
Subject: Re: Question about non-blocking mode in libpq
Date: Tue, 31 Oct 2023 21:55:49 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On Tue, Oct 31, 2023 at 09:11:06PM -0400, Tom Lane wrote:
> Bruce Momjian <[email protected]> writes:
> > Okay, I added "_successful_ calls", attached.  I am not sure what else
> > to add.
> 
> What I'm objecting to is removal of the bit about "if they need to be
> called again".  That provides a hint that retry is the appropriate
> response to a failure.  Admittedly, it's not 100% clear, but your
> version makes it 0% clear.

I thought the original docs said you had to re-call on failure (it would
not block but it would fail if it could not be sent), while we are now
saying that it will be queued in the input buffer.

Is retry really something we need to mention now?  If out of memory is
our only failure case now ("unable to enlarge the buffer because OOM"),
is retry really a realistic option?

Am I missing something?

-- 
  Bruce Momjian  <[email protected]>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Question about non-blocking mode in libpq
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox