Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 2 Nov 2023 07:53:18 +0900
From: Michael Paquier <michael@paquier.xyz>
To: "Anton A. Melnikov" <a.melnikov@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: 003_check_guc.pl crashes if some extensions were loaded.
Message-ID: <ZULW3m1h5K5PvSoD@paquier.xyz>
References: <fc5509ce-5144-4dac-8d13-21793da44fc5@postgrespro.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="mG5MOrJXlIa/M/3P"
Content-Disposition: inline
In-Reply-To: <fc5509ce-5144-4dac-8d13-21793da44fc5@postgrespro.ru>
Archived-At: <https://www.postgresql.org/message-id/ZULW3m1h5K5PvSoD%40paquier.xyz>
Precedence: bulk


--mG5MOrJXlIa/M/3P
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Nov 02, 2023 at 12:28:05AM +0300, Anton A. Melnikov wrote:
> Found that src/test/modules/test_misc/t/003_check_guc.pl will crash if an extension
> that adds own GUCs was loaded into memory.
> So it is now impossible to run a check-world with loaded extension libraries.

Right.  That's annoying, so let's fix it.

> --- a/src/test/modules/test_misc/t/003_check_guc.pl
> +++ b/src/test/modules/test_misc/t/003_check_guc.pl
> @@ -19,7 +19,7 @@ my $all_params = $node->safe_psql(
>         "SELECT name
>       FROM pg_settings
>     WHERE NOT 'NOT_IN_SAMPLE' = ANY (pg_settings_get_flags(name)) AND
> -       name <> 'config_file'
> +       name <> 'config_file' AND name NOT LIKE '%.%'
>       ORDER BY 1");

Wouldn't it be better to add a qual as of "category <> 'Customized
Options'"?  That's something arbitrarily assigned for all custom GUCs
and we are sure that none of them will exist in
postgresql.conf.sample.  There's also no guarantee that out-of-core
custom GUCs will include a dot in their name (even if I know that
maintainers close to the community adopt this convention and are
rather careful about that).
--
Michael

--mG5MOrJXlIa/M/3P
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmVC1t4ACgkQnvQgOdby
QH0qIg/9GB6/8Sja/OsLUsimg2R3xRLEIbiQtd/AIocDGwlqXgYomwC2xcIpYS7m
tzVWYqb9hVqrRHFYG+YU3TT3fe8QyJclBkmuDYumYmPZhQf66kO49aVZvxzFkgLR
Mz/K6yYm733yjxBjbICsrLC8rFdbvLjZV3HmJ8+boqZFSqTElxwnTxkBCCx/9qjd
ze3Bd1bIHxAZjGGZuvqE9No+7dw8oKVqLBIr7AFH/FOJ3AQFsW5+lKfFC7+Do5mP
6ABRudrVwiHohSHzO/7oQjJ7rTcLS0NVuBYrO7mEqgeEjxrLP0lI4MRMSzJ4byfH
xSM1TSI6X0cObQORWX7pSL7XhnZwfa8p0/bfuGo8LqAhor/eJlPz11qel6Y88BUx
Jjg91ccz1qSoRw6EfSbqUVjiISMj6gMFwKX06WZeVkXZnDzfI8WOvm1nxGl3GZVm
ueghXoyJM1ohC0JUxfuH7+A7hQtIHurGEmMYrtz3d8VlqVNntgnIlP9v6FDDzBw1
5SEj4uIDHN3AwvenzNb3AYTIZmHTS8WtBi9nbEyPfeH8eFrffjjdsQtB3k6RaMP7
qMlEUwHqJQZ0YzAfK8O6nTzJG0tMY34R+zOrc1Ldyp1UUJFkfHyrDyGOefxvl+gB
FaCrgUEL9hskCrdC8FK5jw/9Aaryuu3tUEhFyP/5dWtFf3i26iw=
=xRrn
-----END PGP SIGNATURE-----

--mG5MOrJXlIa/M/3P--