public inbox for [email protected]
help / color / mirror / Atom feedFrom: Stephen Frost <[email protected]>
To: Andres Freund <[email protected]>
Cc: David Christensen <[email protected]>
Cc: Matthias van de Meent <[email protected]>
Cc: Peter Geoghegan <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: [PATCHES] Post-special page storage TDE support
Date: Wed, 8 Nov 2023 09:04:13 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAOxo6XKWHHUr1agOZxEHuL-UW8Me3YndUsJ=09tcDiw+Ld8YEw@mail.gmail.com>
<CAEze2WiPj1fTQo7wGCCbs3J9MY3Yj6tdi5uPDQEtnYnrskk0uw@mail.gmail.com>
<CAOxo6XKgNkMPfWZPJYeFgd-qTFxBBAv1QbvySXDLjY7Sr-6KLw@mail.gmail.com>
<CAEze2WiwVws0PcdZhwm-mYb85kF2MZ-APT+bRekpy_D6wVCnvw@mail.gmail.com>
<CAOxo6XKPWaPP+VaETgQiHbR51Tq5HAdWs6-hE6S9+WLi1U4qPA@mail.gmail.com>
<CAOxo6XKL4-=gqSPJFi-=2ZKnnnd9QvVV7=T0sfLjw+ri7LK3qQ@mail.gmail.com>
<CAOxo6XJXTh5O9oQA9zJgTTLybwWNQ8eq-Fpvwtd-5pJO2tBEog@mail.gmail.com>
<CAOxo6XLsKc8ofMh2Ojoh7xBT_4UmeGTHhgTD4hgMRph2UVr8+w@mail.gmail.com>
<[email protected]>
Greetings,
* Andres Freund ([email protected]) wrote:
> On 2023-05-09 17:08:26 -0500, David Christensen wrote:
> > From 965309ea3517fa734c4bc89c144e2031cdf6c0c3 Mon Sep 17 00:00:00 2001
> > From: David Christensen <[email protected]>
> > Date: Tue, 9 May 2023 16:56:15 -0500
> > Subject: [PATCH v4 1/3] Add reserved_page_space to Page structure
> >
> > This space is reserved for extended data on the Page structure which will be ultimately used for
> > encrypted data, extended checksums, and potentially other things. This data appears at the end of
> > the Page, after any `pd_special` area, and will be calculated at runtime based on specific
> > ControlFile features.
> >
> > No effort is made to ensure this is backwards-compatible with existing clusters for `pg_upgrade`, as
> > we will require logical replication to move data into a cluster with
> > different settings here.
>
> The first part of the last paragraph makes it sound like pg_upgrade won't be
> supported across this commit, rather than just between different settings...
>
> I think as a whole this is not an insane idea. A few comments:
Thanks for all the feedback!
> - Why is it worth sacrificing space on every page to indicate which features
> were enabled? I think there'd need to be some convincing reasons for
> introducing such overhead.
In conversations with folks (my memory specifically is a discussion with
Peter G, added to CC, and my apologies to Peter if I'm misremembering)
there was a pretty strong push that a page should be able to 'stand
alone' and not depend on something else (eg: pg_control, or whatever) to
provide info needed be able to interpret the page. For my part, I don't
have a particularly strong feeling on that, but that's what lead to this
design.
Getting a consensus on if that's a requirement or not would definitely
be really helpful.
Thanks,
Stephen
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (5+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCHES] Post-special page storage TDE support
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox