Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 9 Nov 2023 08:05:20 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Remove MSVC scripts from the tree
Message-ID: <ZUwUMMfXnajEU4_c@paquier.xyz>
References: <ZQzp_VMJcerM1Cs_@paquier.xyz>
 <a08e14cf-23c0-b4b6-37f5-dec671e85e7f@eisentraut.org>
 <ZRpzY4Yz9FcW1ZKV@paquier.xyz>
 <d8c7c426-ca50-86be-ce74-d0a8110c40fe@eisentraut.org>
 <ZSeCz50wip_ruKr_@paquier.xyz>
 <3fd0f1bc-4483-4ba9-8aa0-64765b052039@eisentraut.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="4cpZp8xC8kN+Md7R"
Content-Disposition: inline
In-Reply-To: <3fd0f1bc-4483-4ba9-8aa0-64765b052039@eisentraut.org>
Archived-At: <https://www.postgresql.org/message-id/ZUwUMMfXnajEU4_c%40paquier.xyz>
Precedence: bulk


--4cpZp8xC8kN+Md7R
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Nov 08, 2023 at 09:41:19AM +0100, Peter Eisentraut wrote:
> I don't think we should rely on sed being there on Windows.  Maybe it's true
> now on the handful of buildfarm/CI machines and early adopters, but do we
> have any indication that that is systematic or just an accident?

Or both?  When doing builds based on MinGW in the past I vaguely
recall getting annoyed that I needed to look for sed as one thing, so
your suggestion could simplify the experience a bit.

> Since we definitely require Perl now, we could just as well use the Perl
> script and avoid this issue.
>
> Attached is a Perl version of the sed script, converted by hand (so not the
> super-verbose s2p thing).  It's basically just the sed script with
> semicolons added and the backslashes in the regular expressions moved
> around.  I think we could use something like that for all platforms now.

Sounds like a good idea to me now that perl is a hard requirement.
+1.
--
Michael

--4cpZp8xC8kN+Md7R
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmVMFDAACgkQnvQgOdby
QH3lwhAAlSEzTIdHb8nqySs8mU80c8lO3T4kAmPt+XvISFz/FT6Nht1AKu9jaSLc
FVH/t4nf+F+YbJb5TM73q6y+rH7MvIbdjZ8RygVXXWrv7Po6A6+hdokksH4m56y5
FduGU5uAhQ3a5TbcXGxpE6rNDSfQ0R2CgeDVW+76caWADhqzpAaDcu+S3E5rBX9m
UtZVNZkK3sJUv7MuLxLIwUObmHBBmMO2z1lM8k+vIBWjql6/m1OVHFsrwCyY7W1p
Gg/hqDQYhnkz0UvHzw0EbDtok6jB2O3JGHBrb5ND8jaMeHCL9DDOGA3RDUNKM/RO
OVsx9apdwAstWWfEssN9BIKN2gm5ypbuw+71B0uIMgp8UovYGG2RPn86ltcUc6Z5
2KQSl/rycE5/Ex58pjbMKlIsIV5PLQ3lGXyMOYv6QtbV0e2qapGvPoV4xZ00MF68
ImbVTWJuqAfzzO7/cYzGNh/f/BM2RchgOMSeYveDKiHuepKCzP7JaAhPN9i9p0Xo
WWhnhsqZtH9x/E1vhbNypYhVTJIKARAXS/yguGKijMJ8XdmyGOmMphrpWixIn0Pu
xqZix4vwCM3icy/auL51flMij3DB3r6zcGFlBey8H+TzHcnfOuYC1DbWlD+trrnn
r+5ZS3eyGMuRulPrWo1ERKK7Ju9rvdeI8Bca5utjt/49oMFNKS8=
=37UQ
-----END PGP SIGNATURE-----

--4cpZp8xC8kN+Md7R--