Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1r5XQh-00Dtk2-Mc
	for pgsql-hackers@arkaria.postgresql.org; Tue, 21 Nov 2023 20:33:07 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1r5XQg-002AsQ-6m
	for pgsql-hackers@arkaria.postgresql.org; Tue, 21 Nov 2023 20:33:06 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <bruce@momjian.us>)
	id 1r5XQf-002AsI-TH
	for pgsql-hackers@lists.postgresql.org; Tue, 21 Nov 2023 20:33:05 +0000
Received: from momjian.us ([72.94.173.45])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <bruce@momjian.us>)
	id 1r5XQd-006hF6-H0
	for pgsql-hackers@postgresql.org; Tue, 21 Nov 2023 20:33:04 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=momjian.us;
	s=2023062407; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:
	MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
	Content-ID:Content-Description;
	bh=hJVn+2mL6Sn61QoF/TmQ6mobN5HKu+vDeM2ngPR1lrU=; b=2LIVv3yU4vrIB/ek6fgLiXY13N
	arm24C6vdWi1JMp2oNLDfWxHscjE/FtEhxG44euzIt5yoMv/b1Oo6lfAHrJIoVzl4zl0K02Jtnj0H
	6oL7eTme0+2U+iaS+OKe0KZKB1Nh5kAlf6+tshPdXmd94bBGQFyR+YgagAd5Xd1N9kysFk4zKM5tb
	3yuxOWTRYOfZqs2s66odwKM1jL796JKKFjzx7ClJikZXkiIUd6KlevNu5vrqi2Ru8bT18/SD8pa9x
	aJEieve4ymGk9pQ1J7HhJ27a94vBBzkXctkTPLgzmjPXWjzYpAoz+9wBsTSdelU0/klBWAsO3yoxG
	VSmUS+/A==;
Received: from bruce by momjian.us with local (Exim 4.96)
	(envelope-from <bruce@momjian.us>)
	id 1r5XQc-006w13-2P;
	Tue, 21 Nov 2023 15:33:02 -0500
Date: Tue, 21 Nov 2023 15:33:02 -0500
From: Bruce Momjian <bruce@momjian.us>
To: =?utf-8?Q?Mart=C3=ADn_Marqu=C3=A9s?= <martin.marques@2ndquadrant.com>
Cc: David Rowley <david.rowley@2ndquadrant.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: vacuum_cost_limit doc description patch
Message-ID: <ZV0T_jbWurNCzh30@momjian.us>
References: <CABeG9LtsAVP4waKngUYo-HAiiowcb8xEjQvDDfhX_nFi5SJ4jw@mail.gmail.com>
 <CAKJS1f9ofABS2C=nvpfhsQxZdiR=b_6FjKRnoUkM1wPnzhA+7Q@mail.gmail.com>
 <afe7730c-4ba7-3f9f-5184-1debadd18af3@2ndquadrant.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <afe7730c-4ba7-3f9f-5184-1debadd18af3@2ndquadrant.com>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/ZV0T_jbWurNCzh30%40momjian.us>
Precedence: bulk

On Fri, Apr 13, 2018 at 09:56:18AM -0300, Martín Marqués wrote:
> El 11/04/18 a las 02:04, David Rowley escribió:
> > On 11 April 2018 at 09:13, Martín Marqués <martin.marques@gmail.com> wrote:
> >> This is a patch to add some further description, plus the upper and
> >> lower limits it has.
> > 
> > Hi,
> > 
> > +         for vacuum_cost_delay. The parameter can take a value
> > between 1 and 10000.
> > 
> > vacuum_cost_delay should be in <varname> tags.
> > 
> > +1 to mentioning that we sleep for vacuum_cost_delay, but I just don't
> > see many other GUCs with mention of their supported range.
> 
> Thanks David for having a look.
> 
> New version attached with the missing <varname> tags.
> 
> > effective_io_concurrency mentions the range it supports, but this
> > happens to depend on USE_POSIX_FADVISE, which if undefined the maximum
> > setting is 0, which means the docs are wrong in some cases on that.
> > 
> > vacuum_cost_limit seems fairly fixed at 0-10000 with no compile-time
> > conditions, so perhaps it's okay, providing we remember and update the
> > docs if that ever changes.
> 
> I'm also adding a second patch over the config.sgml doc to fix what I
> believe is a misguidance in the minimum resolution time modern systems have.
> 
> The patch just changes *many* for *some* systems which have a minimum
> resolution time of 10 milliseconds.

Patch applied to master, though I removed the valid range part of the
patch.  I also liked the many-to-some change since it is more accurate.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.