Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 22 Nov 2023 09:34:24 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Typo with amtype = 's' in opr_sanity.sql
Message-ID: <ZV1MkCIf4zI0ilJU@paquier.xyz>
References: <ZVxJkAJrKbfHETiy@paquier.xyz>
 <CAJ7c6TOsBVSn46_M6QnWOZtPSPvZMGi-+M8sSaDdtqyWZNCtBw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="gqTl0LVo77RnqVY2"
Content-Disposition: inline
In-Reply-To: <CAJ7c6TOsBVSn46_M6QnWOZtPSPvZMGi-+M8sSaDdtqyWZNCtBw@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZV1MkCIf4zI0ilJU%40paquier.xyz>
Precedence: bulk


--gqTl0LVo77RnqVY2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 21, 2023 at 01:02:40PM +0300, Aleksander Alekseev wrote:
>> It seems to me that this has been copy-pasted on HEAD from the
>> sequence AM patch, but forgot to update amtype to 't'.  While that's
>> maybe cosmetic, I think that this could lead to unexpected results, so
>> perhaps there is a point in doing a backpatch?
>=20
> I disagree that it's cosmetic. The test doesn't check what it's supposed =
to.

Yes, I've backpatched that all the way down to 12 at the end.
--
Michael

--gqTl0LVo77RnqVY2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmVdTJAACgkQnvQgOdby
QH2JPhAAlpsRgTt05tfeCBvLeufkQOArlfCYtU7YN5dogtsc8YqkGlu3kIrijSTZ
UyjKvA+Ioi3BDbVWkoJmd5KrjguDyko7np50yz6HuIOd2jSTvmaxYj9a4OAfmdOt
/oV1MEABWkOptrZG3zVQI3z9cXJqcoRqqKTD85PTwfvETfJEY/y73OCYph/WqKlp
wvgQzTx7/BARJvxrN/XER7opwjZ9TLooNXW4JNsyfpkUsAi724PS8wLbEe5ThnbO
X+Ojob19Hf7PsXq2lYxtOTom2XrvY1yd+B+3LuS4xpWpPZo4SRtw7/HtMetT8hwO
nZm4h3t9BKUZmdP4RpYA/hjo4bB1iP5+E7qjS/okUF4Tq8KvXZL9phs7mBZAMse6
ROtwtH+wVxo4Pniw9IHxrS5jthOoX+v3GeoFEOE/nqrFpozis9YYomYwTAzeCLnG
BB7tO93W8FHT14+x3JyWxJFBEBepC1FsWTe5RUKjsb9rBCHgf14aPy1MSo7ddkkE
ggDyYe7FCeHfu/pwD8frlIL8YnOIP7DNYgI4K8LY3QZvz3PjGVlFclZwLa3KzasV
Nc9Ayrr1ak/4qFBLKunWzouD4RHEc+0R7ZqqV4LoN/XIj1g1rKq3GibpWauLRtAt
wz+YaPUQdLu8glnmunjCsZF0BiJ4hPK8pLZ4MvNC6lQI+eVGJm8=
=pikA
-----END PGP SIGNATURE-----

--gqTl0LVo77RnqVY2--