Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r2PXV-00GZE6-31 for pgsql-hackers@arkaria.postgresql.org; Mon, 13 Nov 2023 05:31:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r2PXT-00D1Eg-M0 for pgsql-hackers@arkaria.postgresql.org; Mon, 13 Nov 2023 05:31:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r2PXT-00D1EY-Cl for pgsql-hackers@lists.postgresql.org; Mon, 13 Nov 2023 05:31:11 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r2PXO-005JVt-8i for pgsql-hackers@lists.postgresql.org; Mon, 13 Nov 2023 05:31:10 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 4F6975C0081; Mon, 13 Nov 2023 00:31:05 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 13 Nov 2023 00:31:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1699853465; x=1699939865; bh=mw +5sjpBEn1y8Y9RbETWnQ8juugmmCPvfyDtmxOH8BQ=; b=PJKkQh0Ep2rKDuT1ca rqU27urTJHxG2WuNfU/3ITmcElXDv4FqPYGu1mGe9pRM5P//itopsbWYbMipfUZT jL7TQFMLlDxnUjav5TbmaCD6sV5za2qF+LJ2O6Gjdi7YvEXE7VnM8t+pE1xzEBxo 9XYLcVhyErAi/JAF7h/LPaUK98I2DUil2l8OufjcTr0FikM72Fref2FPlwuWBA0N hkqiRD8CozK9EpUJ8C+qEjnb0OOCpqwqVsGpW+xp9HisTj/+Mj+qfsnxnq0y8pAU DNaHwryS+p45+jeMtbAWfW/O/9fy/WMhzT+1dBNT2q/sMBjHenJfS4Qyo1fNsLhL Feew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1699853465; x=1699939865; bh=mw+5sjpBEn1y8 Y9RbETWnQ8juugmmCPvfyDtmxOH8BQ=; b=NXWxq2uQP+trcHAFR3Ke8er0n5Zim IX1GTmHAupf6iuuCu0n1D1k03naKbt6D4kE5DxJnAPJ8ikk8FlrQe2Ni0Uypl06o nKe1YInKDI0i36He11JTAfNg4rap+F2kbwPJYf1WQUWW4zmKlIq9ECfrn5doebHF 5e8LnuLH7PowvKtWf/GSH2K+2s4bSm5/bt2CPEq4ouhQXL4ks+yDpblLdAxvrUju kHeOOctqsvM3RZbV/7kEWI13ZaNw05Mu4XtxeW1ji+RNU6W7MR1vzV1yom3lpWNn qophTtVZ+jTWj9oiEnvIbji5lYPyMdwtIXtzxXCSaJMzh7lE9aOo9Wfqw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvledgkeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 13 Nov 2023 00:31:03 -0500 (EST) Date: Mon, 13 Nov 2023 14:30:48 +0900 From: Michael Paquier To: Peter Eisentraut Cc: Postgres hackers Subject: Re: Remove MSVC scripts from the tree Message-ID: References: <3fd0f1bc-4483-4ba9-8aa0-64765b052039@eisentraut.org> <9f37249d-d159-46a5-afe0-b5eecd7ff6c2@eisentraut.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="i3Yvxep7KJrxrtUo" Content-Disposition: inline In-Reply-To: <9f37249d-d159-46a5-afe0-b5eecd7ff6c2@eisentraut.org> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --i3Yvxep7KJrxrtUo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 10, 2023 at 08:38:21AM +0100, Peter Eisentraut wrote: > How about this patch as a comprehensive solution? > 8 files changed, 26 insertions(+), 339 deletions(-) Thanks for the patch. The numbers are here, and the patch looks sensible. The contents of probes.h without --enable-trace are exactly the same before and after the patch. In short, +1 to switch to what you are proposing here. -- Michael --i3Yvxep7KJrxrtUo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmVRtIgACgkQnvQgOdby QH1DWQ/+Iz6355FLXlTjX3iVM8K+xWA4Dhi01jymxElC4JWAy9QyzlQRhcb5aT1y 7oP6ypujl0Bp0EcjVB9DC93EE1jpaPF98aWQiwTKktFFIjM+kZTySnWC6+/x78Oq zzX2tTx3WFZefwFix/tM+NB5ufsBGyMMjaqTvjdCxuXQ8O3yVESPEGAagzyfPLtV 0IJQF+/L6lwx7RC0w42hVIQ9cHBs73u9w4Tk4gSPOD36JOFUgcAX7hc/hwGOLb9R g6trtS4MeymbDEtuEkGEayXkDiHusa8WEi4qTddXvSTXbvfFzVjkbUYtqMKk/iEv s9igMwlEB9qQcqEa0ZF5XxWSF8mWgkGPQBehS0Ta1x/U2dTLlVCDkrJUF1sZdSVo lqs0KGnO0aX2xrY/uwFaFEM+qbp1ZB6Me3UjkMoTAo3HJNUpeiNTDfUZnacBPXjW 6BHzD3qw/HCBuxZxkYpbEO/dq35AB9WynqPGT38qgBRXjGlaewrVzDohM7Cteyp6 BtkBBcRQrb8B5T49JCig7AkIYAV+QdAJhanaIE28tVWqB+0nT+f3XYlP0UIexAv2 QKAqvA7Dn8Nr4+ys47ksUTKLw6zmyudQZ7EfjJt8LriyLrJm0f+KrkSioCA9lZJ6 bWPVfvDWqVwZdhGq1nh2leKaQasZlGAQ47ezlEUQmHEOQTaiYYA= =aaYi -----END PGP SIGNATURE----- --i3Yvxep7KJrxrtUo--