Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r2PvB-00Gac6-P3 for pgsql-hackers@arkaria.postgresql.org; Mon, 13 Nov 2023 05:55:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r2PvA-00DG9Z-Ch for pgsql-hackers@arkaria.postgresql.org; Mon, 13 Nov 2023 05:55:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r2PvA-00DG9R-3P for pgsql-hackers@lists.postgresql.org; Mon, 13 Nov 2023 05:55:40 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r2Pv7-006ATt-B8 for pgsql-hackers@postgresql.org; Mon, 13 Nov 2023 05:55:39 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4664E5C00E5; Mon, 13 Nov 2023 00:55:35 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 13 Nov 2023 00:55:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1699854935; x=1699941335; bh=zc Go39YEHpqBS4wfM8g1BkxCurUwC9yOnUTNAP+lUbM=; b=w53wCiDzFr89TFQ8eD pwoEoMJeqgwmqlpPelNBu7h6b5bIeZWWz/Jc8j0WHPrw5ojVIEFT76Jx4JJUmpUp H1E4Npw/TF9bJAJ+rmpxcsOQW17NPlWVJzZ+qu+G1owfoNJfWAuaeitAzxJ7Iwii Lap0g4MCFUvyutpn/rZD2iv94HEGhjt0yx7w8uvXqCDWwTPa5o/aNGYHYxDWoJ7r S7GSZfo95aV9dg+Jw7BSaKldmdrbwC537fsj0zCGkR80ffQbzWAI9rRC1e1NMSpU /U1VjsoQtrtPZcJhTUol2WrSW1t3iIgHbpUq7jhBF+7pO8oCBldG+h33dLNSatHf vFrw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1699854935; x=1699941335; bh=zcGo39YEHpqBS 4wfM8g1BkxCurUwC9yOnUTNAP+lUbM=; b=MnjlVs1NYvu4RPtlmaaxNhItUVH58 WSnOzIH7v8vDPEz4+WX7q+gfAszU7liZRoK6oKPwvC+ieuQm8bfybQNQWIbxvevv Pki/ugTcfffLRP+AFjTDhTdCt5HuSA7jmi73hTm8db1axbaJmwT7uBspa9FmTd9M yKF9V8L6/QhzGQShYuN4KS5jtzLTqtQ7iHVkxTiRlHR3TF2dxxmbUoRQ34zcEY97 sirs+Z2Kr71fTZptp8z2OVojgubAHG857vY7xnTfJ7Dk64Zv9L3zHNEqmp+3d3VE BsnKK57e9UVxqQslwsAxgDxVH3WBfk0Ds+zAN8SVAARpnNlUJppof2xaQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvledgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlfeehmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepgeffjeevgfevuddvjedtvddt ieejheduueelvddufedtgfefjedvkeevkeeivddvnecuffhomhgrihhnpehpohhsthhgrh gvshhqlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 13 Nov 2023 00:55:31 -0500 (EST) Date: Mon, 13 Nov 2023 14:55:19 +0900 From: Michael Paquier To: torikoshia Cc: bharath.rupireddyforpostgres@gmail.com, Andres Freund , boekewurm+postgres@gmail.com, Kyotaro Horiguchi , pgsql-hackers@postgresql.org Subject: Re: Add new option 'all' to pg_stat_reset_shared() Message-ID: References: <62d8244b05557a91e25914c02607b493@oss.nttdata.com> <20231109012952.fft2i356ofljugt6@awork3.anarazel.de> <37bce6feca33e0c0441cd33f9eaa51d6@oss.nttdata.com> <89C9D2DC-8239-4373-991A-18CC45D6A5FE@anarazel.de> <6c01af77007905c73751f42eea03aef5@oss.nttdata.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="J54lGJ9W8ljQPazk" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --J54lGJ9W8ljQPazk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 13, 2023 at 01:15:14PM +0900, torikoshia wrote: > I assume you have already taken this into account, but I think we should = add > the same documentation to the below patch for pg_stat_reset_slru(): >=20 > https://www.postgresql.org/message-id/CALj2ACW4Fqc_m%2BOaavrOMEivZ5aBa24p= VKvoXRTmuFECsNBfAg%40mail.gmail.com Yep, the DEFAULT value and the argument name should be documented in monitoring.sgml. -- Michael --J54lGJ9W8ljQPazk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmVRukcACgkQnvQgOdby QH0W/A//agsKIN0U/cp+d7OuEpKmZvvimxf+d5iwxZXRKxb7cxI+GjnIbR1oE9kb W31yOfesehRa8RwSg0dDA5u9TTR6Qvxj7mM53wql6IIfCT6mIiXICgzFoiZOX2ma zMgvybL2GW9KgwsZrg/3DFp/6EhVMOmrzmOb78TMZC/GmDjvnwbqvLzjNA0FclGf Kzjd0atCaSQrQvBAXkNNr/m10Gf3fDrUPqHz0xRck3kKlqNWjRLqU6xTOp8yWW2J 8MRsILjKN77zWqJMEMfZo7ASiItT7eRyMdzVVJxhdwkv0A/PmOE3hbci729NEGuH FJrCBK46e2CD+K47R2/HiAzYdRQVDPb7SJwoDsCyn5quppD7traF7uzo8NSQmx99 0/UoQGUWjefQXCyRuoS2xDLYx9RGbocRVO4/QoOaUcnn+i32pAE9/bJ4ws6qSfmK aDy8ZW7m269D2Ec24T+jEk2ELa2eegZu9+WFRSdA6s/U0D6x7ahFQLKTPMmH5/Jz tPXUNhAcURDiSli0a0ogU0+lqqyyLcorP9RwTFT7Sp18QNSK+HddwO1DA1lZj9me swsdjC/xUPU0IAO++5VaWuETXe5XuEHENJIbZe2mHe+2DRxtdhxAaYZLWZjOucMx wcN0XTdRYXOdIvnNoGUy5/B81+x63dKPcADLWU6ArCGiks2bT9o= =40CG -----END PGP SIGNATURE----- --J54lGJ9W8ljQPazk--