Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 21 Nov 2023 15:09:20 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Typo with amtype = 's' in opr_sanity.sql
Message-ID: <ZVxJkAJrKbfHETiy@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Y1lLLxQ5r4Syo4Ql"
Content-Disposition: inline
Archived-At: <https://www.postgresql.org/message-id/ZVxJkAJrKbfHETiy%40paquier.xyz>
Precedence: bulk


--Y1lLLxQ5r4Syo4Ql
Content-Type: multipart/mixed; boundary="U89T2T5DbuN0UWFa"
Content-Disposition: inline


--U89T2T5DbuN0UWFa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi all,

While rebasing a patch from 2016 related to sequence AMs (more about
that later), I've bumped on a mistake from 8586bf7ed888 in
opr_sanity.sql, as of:
+SELECT p1.oid, p1.amname, p2.oid, p2.proname
+FROM pg_am AS p1, pg_proc AS p2
+WHERE p2.oid = p1.amhandler AND p1.amtype = 's' AND

It seems to me that this has been copy-pasted on HEAD from the
sequence AM patch, but forgot to update amtype to 't'.  While that's
maybe cosmetic, I think that this could lead to unexpected results, so
perhaps there is a point in doing a backpatch?

Thoughts?
--
Michael

--U89T2T5DbuN0UWFa
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="opr-sanity-amtype.patch"
Content-Transfer-Encoding: quoted-printable

diff --git a/src/test/regress/expected/opr_sanity.out b/src/test/regress/ex=
pected/opr_sanity.out
index 7a6f36a6a9..7610b011d6 100644
--- a/src/test/regress/expected/opr_sanity.out
+++ b/src/test/regress/expected/opr_sanity.out
@@ -1920,7 +1920,7 @@ WHERE p1.oid =3D a1.amhandler AND a1.amtype =3D 'i' A=
ND
 -- Check for table amhandler functions with the wrong signature
 SELECT a1.oid, a1.amname, p1.oid, p1.proname
 FROM pg_am AS a1, pg_proc AS p1
-WHERE p1.oid =3D a1.amhandler AND a1.amtype =3D 's' AND
+WHERE p1.oid =3D a1.amhandler AND a1.amtype =3D 't' AND
     (p1.prorettype !=3D 'table_am_handler'::regtype
      OR p1.proretset
      OR p1.pronargs !=3D 1
diff --git a/src/test/regress/sql/opr_sanity.sql b/src/test/regress/sql/opr=
_sanity.sql
index e2d2c70d70..2fe7b6dcc4 100644
--- a/src/test/regress/sql/opr_sanity.sql
+++ b/src/test/regress/sql/opr_sanity.sql
@@ -1223,7 +1223,7 @@ WHERE p1.oid =3D a1.amhandler AND a1.amtype =3D 'i' A=
ND
=20
 SELECT a1.oid, a1.amname, p1.oid, p1.proname
 FROM pg_am AS a1, pg_proc AS p1
-WHERE p1.oid =3D a1.amhandler AND a1.amtype =3D 's' AND
+WHERE p1.oid =3D a1.amhandler AND a1.amtype =3D 't' AND
     (p1.prorettype !=3D 'table_am_handler'::regtype
      OR p1.proretset
      OR p1.pronargs !=3D 1

--U89T2T5DbuN0UWFa--

--Y1lLLxQ5r4Syo4Ql
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmVcSZAACgkQnvQgOdby
QH0ZMg//XIeo3ffw3VGcEIytOv+tiPIDZLXUUbfK25B/dJ7hXxhSEkiwAdR6D5hv
YtR/3OhIdTtPOnegsGrHSeUohCmYnGR2VtRuhdSYKESVYAYrmID//6nQLGM7mQ7g
0SMCPa1uWyAU7X0IURUTHMwSnqwVc0/C366szm+v2Oh0dlgX2j1mB+DGW++rHsdD
Rcpiq14Lzpj4SNbW12k4TYUN7ZD9OPFSQ73iqu2dsbf/igoNNl0tL0rFo0uFCRGf
JucubUPkotvdDModNi0ibZsEMnH3V4sNDufXEkOA8DNvPCH8yluNCqmhLoGRJzb7
3eTTzafb17FtQ9ZmigXJpGnKh2Q5EZopjlnLUCAWH/DsEKO+i3ZclfTw0/gJnLxw
7Fsm2bF7t2sMRM0bi3YTzd/ufF8zKJtOrWj/WUWjLCKfVXwKJFcHxdd09dpJTFZ9
nkoGl1Zb565uyW51Vsu5t/Ip79HKQTW3yQELkC1uOa8oh02EzDum8V7Ek4C11kyX
0X3ay+JNgetB9zOyYTMGD7cWnHhwcYTuQm4/ZGkDYTYTaOqovnpOb+B0JTKsDJa2
w6R4CMURdiIbdqjdInM0OscQ/1aPDOwvqJJadNdClo9NImqrwWCitlfedYydofmy
xB4MeWKhZEfWnVU4EryDO4P7BLMlHXrMkve2uUuzN6E7bwvAqm4=
=9sp2
-----END PGP SIGNATURE-----

--Y1lLLxQ5r4Syo4Ql--