Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 4 Dec 2023 16:59:48 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Failure with pgbench and --disable-thread-safety in ~v16
Message-ID: <ZW2G9Ix4nBKLcSSO@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="vIFQwWrXFfZZHy3h"
Content-Disposition: inline
Archived-At: <https://www.postgresql.org/message-id/ZW2G9Ix4nBKLcSSO%40paquier.xyz>
Precedence: bulk


--vIFQwWrXFfZZHy3h
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi all,
(Alvaro in CC.)

While running some tests for 8984480b545d, I have noticed that the TAP
tests of pgbench fail when ~16 is compiled with
--disable-thread-safety:
[16:51:10.467](0.004s) not ok 227 - working \startpipeline with serializabl=
e status (got 1 vs expected 0)
[16:51:10.467](0.000s)=20
[16:51:10.467](0.000s) #   Failed test 'working \startpipeline with seriali=
zable status (got 1 vs expected 0)'
#   at t/001_pgbench_with_server.pl line 845.
[16:51:10.467](0.000s) not ok 228 - working \startpipeline with serializabl=
e stdout /(?^:type: .*/001_pgbench_pipeline_serializable)/
[16:51:10.467](0.000s)=20
[16:51:10.467](0.000s) #   Failed test 'working \startpipeline with seriali=
zable stdout /(?^:type: .*/001_pgbench_pipeline_serializable)/'
#   at t/001_pgbench_with_server.pl line 845.
[16:51:10.467](0.000s) #                   ''
#     doesn't match '(?^:type: .*/001_pgbench_pipeline_serializable)'
[16:51:10.467](0.000s) not ok 229 - working \startpipeline with serializabl=
e stdout /(?^:actually processed: (\d+)/\1)/
[16:51:10.467](0.000s)=20
[16:51:10.467](0.000s) #   Failed test 'working \startpipeline with seriali=
zable stdout /(?^:actually processed: (\d+)/\1)/'
#   at t/001_pgbench_with_server.pl line 845.
[16:51:10.467](0.000s) #                   ''
#     doesn't match '(?^:actually processed: (\d+)/\1)'

This ./configure switch has been removed in 17~, and, while I've not
analyzed the problem in details, I am wondering if this points to an
actual bug with \startpipeline in all branches.

Thanks,
--
Michael

--vIFQwWrXFfZZHy3h
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmVthvQACgkQnvQgOdby
QH3t8w/+KNlIzf3yYBI0IhVND4RezgBg1DKCUU1NNURl8Dm5GOjAWbye7LbSBaEj
8qPtXCsUB0NSOcQoBo6NvCTHI4gel9AXIWWZtoL8/SgmwJsEA0awbLG9FavyGY6M
HxYL98UQY1d6L9nIpbMaJ8c793Oe9rh1zzSw4O3vwnTSWomSe5oXmU9HCY4bCgW+
4oaV77apolgd6m3N/lepcPb1sJsDwaei0URIcZ69J6BVykPcP6fiOgynghXFTPuC
PMnvBau7G9Qt9CTOBuMHZ4whbllHLQ4Y+NwgKYUWdkt6NzJIlQrhvY+89rKzF0WT
owCKHHfuKwLe7SJugVbHKQO/B8ssE4gSKPObkX2Q8/hJd4qMeTWwUVca4wdgUq5a
g9esDq+2IWogSoa7a081PUgCVObTseNZK+Apo+1DK9JvnnNiiu3BpuSC/F4U3Mnu
IQDGKjf+wYrt+UqhF2vqmn2WEIyGoUsojyYYc/jXvsbvThO/QdBe7o6VbX4jaFky
h1mMHOj+8ADuJ6st7rNsuhqEAaOnWlRruvfTMZ4iDj6Iud7UWTai6EwbV1wZUTsM
5QgrbLKxd6F4ukNk5F1qvuKzL+gNgGD/pQmfUo8YexPsiEt6xeYlmzTaDqxS6yKt
sfKwRkPBiorZI+T9h/TRk/dQPsHuoTaznG8+BuYUrJkHz23XfCQ=
=qEvo
-----END PGP SIGNATURE-----

--vIFQwWrXFfZZHy3h--