public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Ashutosh Bapat <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: Re: Adding facility for injection points (or probe points?) for more advanced tests
Date: Fri, 24 Nov 2023 23:07:23 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAExHW5usVs10M4i5RD68r5fpbr3mdzePnT589nT4X3cm7L64sQ@mail.gmail.com>
References: <[email protected]>
<CAExHW5vZXq8WiTFiCfzk-f7Sqi+TMZ0Ty6XxehUZ9o91GP_AJA@mail.gmail.com>
<[email protected]>
<CAExHW5skzA6UPEYALz4GkCZdJZBt94uWahp5fExu09S90e1iHQ@mail.gmail.com>
<[email protected]>
<CAExHW5usVs10M4i5RD68r5fpbr3mdzePnT589nT4X3cm7L64sQ@mail.gmail.com>
On Fri, Nov 24, 2023 at 04:37:58PM +0530, Ashutosh Bapat wrote:
> Interesting idea. For that the callback needs to know the injection
> point name. At least we should pass that to the callback. It's trivial
> thing to do.
This is what's done from the beginning, as well as of 0001 in the v5
series:
+INJECTION_POINT(name);
[...]
+ injection_callback(name);
> That might work, but in order to run tests in that directory one has
> to also install the extension. Do we have precedence for such kind of
> dependency?
Yes, please see EXTRA_INSTALL in some of the Makefiles. This can
install stuff from paths different than the location where the tests
are run.
>> and that there are no string objections, so feel free
>> to comment.
>
> Let's get some more opinions on the design. I will review the detailed
> code then.
Sure. Thanks.
>> I don't want to propose 0003 in the tree, just an improved version of
>> 0004 for the test coverage (still need to improve that).
>
> Are you working on v6 already?
No, what would be the point at this stage? I dont have much more to
add to 0001 and 0002 at the moment, which focus on the core of the
problem.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Adding facility for injection points (or probe points?) for more advanced tests
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox