Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 27 Nov 2023 12:03:45 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Willi Mann <w.mann@celonis.de>
Subject: Re: [PATCH] fix race condition in libpq (related to ssl connections)
Message-ID: <ZWQHEdF1_NOI4jOS@paquier.xyz>
References: <e77abc4c-4d03-4058-a9d7-ef0035657e04@celonis.com>
 <CAJ7c6TN5KxKhCkHc=MJV=K3v9q98Pmfs=ZQ6pwTKMzRnikJfCQ@mail.gmail.com>
 <ZV1cxFxcvPDDJkpi@paquier.xyz>
 <ZWBVapzofU5P0IoW@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="AaCIYPY9iGc0oVav"
Content-Disposition: inline
In-Reply-To: <ZWBVapzofU5P0IoW@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/ZWQHEdF1_NOI4jOS%40paquier.xyz>
Precedence: bulk


--AaCIYPY9iGc0oVav
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Nov 24, 2023 at 04:48:58PM +0900, Michael Paquier wrote:
> I've looked at this idea, and finished by being unhappy with the error
> handling that we are currently assuming in my_SSL_set_fd() in the
> event of an error in the bio method setup, which would be most likely
> an OOM, so let's use ssl_config_mutex in my_BIO_s_socket().  Another
> thing is that I have minimized the manipulation of my_bio_methods in
> the setup routine.

I've spent more time on that today, and the patch I've posted on
Friday had a small mistake in the non-HAVE_BIO_METH_NEW path when
saving the BIO_METHODs causing the SSL tests to fail with older
OpenSSL versions.  I've fixed that and the patch was straight-forward,
so applied it down to v12.  I didn't use Willi's patch at the end,
still credited him as author as his original patch is rather close to
the result committed and it feels that he has spent a good deal of
time on this issue.
--
Michael

--AaCIYPY9iGc0oVav
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmVkBxEACgkQnvQgOdby
QH2oxA//dnKYTCvlDZdEO8xNikl0y//srmjC/ctIZbs2onXeiaW7cJsVBiAxxe4l
j9fPjvOkPj9e9ePDuLV0EvSl1bbRkPaBkHTce6Zw0HA0sKK4Nt9VMYdUJG6eg5ab
OLHSEvER1KKLGOqC0YqZiA5y1Aa7jW/HBoqt9GhngKKfLxxfyMeFUH54hciz9nOB
frOHSEz6yexW+UodAuaLxjghe/Cn0IQxwm4T1JPHpDIZToNA6d4VYPjnDz41VPQ9
UYucDC7GeS5TAoqjBEzsU9Oh56fZ03dqvvn6rAcJLUt6/l3ZEhWw6XiEMVEblH7b
Vb8sWNSL+ew3vrBkBmeOF7681Iq0pRt6zsWDvw60eFlSn8ktK9CVumlCIsgNNmAD
dbgbrjnaVfnpyGmCwzuO3HO7Lz932IOsTX+EQ/mm4G7D1QgSRhY+/lzmIVYEK0lt
8bdae4/9Y9O1/ZkUANXYSwXAe/6a5EK+/jcen/w7GBcTQWm5H21ucL2KyFktrpI0
P80L+CaSRGzmN4XbRjRFWJyvlrJvMMo6JHr1a/rtio9+dY9vxF0i1yLMJ0SgsYM8
z/GvFYH1C8/2JK1AJxI2dz9k3Wx/nPTBFqBGSOfo88hJEnrwv1enjeWQPG+9VNE7
WO1/i+T4Iw0fTwSwdPWFAH81QpUQuQB211rcnTdJwFAn2UEAoyc=
=B32P
-----END PGP SIGNATURE-----

--AaCIYPY9iGc0oVav--