Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 28 Nov 2023 07:53:37 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>,
	Peter Smith <smithpb2250@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Nathan Bossart <nathandbossart@gmail.com>,
	Peter Eisentraut <peter@eisentraut.org>,
	Daniel Gustafsson <daniel@yesql.se>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: GUC names in messages
Message-ID: <ZWUd8dYYA9v83KvI@paquier.xyz>
References: <ZWAUV4fdjFw5nWvj@paquier.xyz>
 <202311240953.6linnh7oxsdn@alvherre.pgsql>
 <CAHut+Pu91ik+U1ffV4e9a7R_aHFdqNrF8mBJ4FYtPfo8oDL6Yw@mail.gmail.com>
 <ZWP0VoXV8QYBGwhC@paquier.xyz>
 <CAHut+Pvy=7Sk8Jz9YzU+0Brp1Ki=0DNz6eRgosDCfAAaT+vWHQ@mail.gmail.com>
 <db3e4290ced77111c17e7a2adfb1d660734f5f78.camel@cybertec.at>
 <3772065.1701066944@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="4Y4bYeRVx4mHX0BZ"
Content-Disposition: inline
In-Reply-To: <3772065.1701066944@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/ZWUd8dYYA9v83KvI%40paquier.xyz>
Precedence: bulk


--4Y4bYeRVx4mHX0BZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 27, 2023 at 01:35:44AM -0500, Tom Lane wrote:
> Laurenz Albe <laurenz.albe@cybertec.at> writes:
> > On Mon, 2023-11-27 at 13:41 +1100, Peter Smith wrote:
>>> In the documentation and in the guc_tables.c they are all described in
>>> MixedCase (e.g. "DateStyle" instead of "datestyle"), so I felt the
>>> messages should use the same case the documentation, which is why I
>>> changed all the ones you are referring to.
>=20
>> I agree with that decision; we should use mixed case for these parameter=
s.
>> Otherwise we might get complaints that the following query does not retu=
rn
>> any results:
>>   SELECT * FROM pg_settings WHERE name =3D 'timezone';

(I'm sure that you mean the opposite.  This query does not return any
results on HEAD, but it would with "TimeZone".)

> Yeah.  Like Michael upthread, I've wondered occasionally about changing
> these names to all-lower-case.  It'd surely be nicer if we'd done it
> like that to begin with.  But I can't convince myself that the ensuing
> user pain would be justified.

Perhaps not.  I'd like to think that a lot of queries on pg_settings
have the wisdom to apply a lower() or upper(), but that's very
unlikely.

-    errhint("Perhaps you need a different \"datestyle\" setting.")));
+    errhint("Perhaps you need a different DateStyle setting.")));

Saying that, I'd let this one be in 0002.  It causes a log of diff
churn in the tests and quoting it based on Alvaro's suggestion would
still be correct because it's fully lower-case.  (Yeah, I'm perhaps
nit-ing here, so feel free to counter-argue if you prefer what the
patch does.)
--
Michael

--4Y4bYeRVx4mHX0BZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmVlHfEACgkQnvQgOdby
QH2rnA//f+2dEsz4EadPP49+Sk/PBn6DT2C+1twD3qOMRPu7Kn5c0kpPg15vg+GG
eLF+06gPNSO4AGMMxdaiqnjqsnbLYsRSDZ+POX1H0K532/q5j6Rd0IZcD5fXMEv6
193DkR0wgSdTg9BFgcE4NEJ+sv3A4rEA3y0LkEw+szuHX2l2idSOtXbxEmqMSoWa
uStp3KBP9Y09QyfADjpLIf347n2cY8Az/YNQOWOsfVySoCBt7/OFr1qZJ+tgH9XP
mimHAVMmfbdj8AMfCnoFe0kd3nfncEwWfH820Gg9eaJqBf+Su2KI+d6H1nUMk2uk
DYET2sedyFyYkcVsMNOFw/UDBeErpNLJCyj30MRu8wQupHBwMyykUGS7ZKTm1xtx
IwfweYfhGVL1yQT1r8dUF+tReKRLyW+apnW1QJFEF62IbVNRUEbgE2YEk12f+Yci
OPaMCtGu3dNtrTwfTWtgrvBBOtT0d6D7LO7rDyId0+s0j98vYFWYJZzXnIL7FoIl
01J4ahGIcRYMD4lL5AeMSjUMoyrPE+B24d/d0CIStLL1xitEFlWSAvAVOo6Nt2Vt
kvcwWyqCBwt3h1I4263oi0PVqj/SwOVKgFLLyqqQfzK7JU7KEz5hZN8QCec/+AxK
RyR37OVyrT4eXWsjmDbXNtM9kVthWVextSXgjjnhwMt59L9e1aM=
=345d
-----END PGP SIGNATURE-----

--4Y4bYeRVx4mHX0BZ--