Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 16 Dec 2023 10:33:45 +0100
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Peter Smith <smithpb2250@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Nathan Bossart <nathandbossart@gmail.com>,
	Laurenz Albe <laurenz.albe@cybertec.at>,
	Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: GUC names in messages
Message-ID: <ZX1u-QVlAowc4CT2@paquier.xyz>
References: <CAHut+PsXEqjxdvR6sZX6ihgWhK8jwk=L7VJdAJJT+hwAVwwj7w@mail.gmail.com>
 <ZWAUV4fdjFw5nWvj@paquier.xyz>
 <CAHut+PtOqRPyVuX=xL=EhDAEWkpBh2MgeSW1KoyMjru-tEWO9w@mail.gmail.com>
 <CAHut+PusWzeZBcOnn07m8TLHJBRiD8HCOV8QPwOwagFv3fs4kA@mail.gmail.com>
 <ZWgkuTmMItANLpnU@paquier.xyz>
 <00b8d030-15cb-4609-b34a-98519b4c4c3b@eisentraut.org>
 <CAHut+Ps3Lbo=hGevYf8AyjFo8+=SSwXUo7onB-6nS6e-Q-bQoQ@mail.gmail.com>
 <9e7802b2-2cf2-4c2d-b680-b2ccb9db1d2f@eisentraut.org>
 <CAHut+Pss00B5C9+Urg1yKUPL41O_atvTTTiG8WZ_SsNUfJVfQA@mail.gmail.com>
 <6d66eb1a-290d-4aaa-972a-0a06a1af02af@eisentraut.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="YzlsFT6RVvAij316"
Content-Disposition: inline
In-Reply-To: <6d66eb1a-290d-4aaa-972a-0a06a1af02af@eisentraut.org>
Archived-At: <https://www.postgresql.org/message-id/ZX1u-QVlAowc4CT2%40paquier.xyz>
Precedence: bulk


--YzlsFT6RVvAij316
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 14, 2023 at 09:38:40AM +0100, Peter Eisentraut wrote:
> After these discussions, I think this rule change was not a good idea. It
> effectively enforces these kinds of inconsistencies.  For example, if you
> ever refactored
>=20
>     "DateStyle is wrong"
>=20
> to
>=20
>     "%s is wrong"
>=20
> you'd need to adjust the quotes, and thus user-visible behavior, for
> entirely internal reasons.  This is not good.

So, what are you suggesting?  Should the encouraged rule be removed
=66rom the docs?  Or do you object to some of the changes done in the
latest patch series v5?

FWIW, I am a bit meh with v5-0001, because I don't see the benefits.
On the contrary v5-0003 is useful, because it reduces a bit the number
of strings to translate.  That's always good to take.  I don't have a
problem with v5-0002, either, where we'd begin using the name of the=20
GUC as stored in the static tables rather than the name provided in
the SET query, particularly for the reason that it makes the GUC name
a bit more consistent even when using double-quotes around the
parameter name in the query, where the error messages would not force
a lower-case conversion.  The patch would, AFAIU, change HEAD from
that:
=3D# SET "intervalstylE" to popo;
ERROR:  22023: invalid value for parameter "intervalstylE": "popo"
To that:
=3D# SET "intervalstylE" to popo;
ERROR:  22023: invalid value for parameter "IntervalStyle": "popo"

> And then came the idea to
> determine the quoting dynamically, which I think everyone agreed was too
> much.  So I don't see a way to make this work well.

Yeah, with the quotes being language-dependent, any idea I can think
of is as good as unreliable and dead.
--
Michael

--YzlsFT6RVvAij316
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmV9bvkACgkQnvQgOdby
QH1jQA/+NyZBXQwoqQIRUj/oqzWEvgUpJPHxpIP4K8g9eRukAa7+vfSDkvlM3R9s
CN5gDPYKijQEzCbGvljADhhMno4aKAmom0+GTwDOXhtByXs8seKcLk7a7z24Nol0
tR2K/UsHBZsEyoL82I2Bbr3c8qb1lOvTHGHRtOZhvuoXE/lfxXJuhcS6Qo9dH4Bh
46ysTWqcadm88AptQp5OPVuTr438WoGVOSVykG2OJyjDf4UeqJVJ6rhcg2La3HeC
rzLlRKkOqqPIVAQngSaThQrQR/rb7OrxVUfMZ5AKHzw4V+WGjLsDVQWHiClxaG56
jFkSiHiTn+ugJKJaDZE7fDalwEvvjS5Z+8AxWk71fJHVgNoMVZrennNmexoK83EV
xZgtDcx5ukEQNbBABwGR9dzx7nxwY2ibRE83PehKlG7tDVQl/PSt6menfKUxcVaH
9cKZDFkpQj066NNW2wo+E04r2hrsunvC3B7Ibw2v3ceL5ctETX5aV1MDzAt5Qob4
sjRRbye/BZoLkk1S94dbnxUaLxWAwsaZ+DH4NX5i1FEAcVue4hEe4UkRGuPNRLDe
G//mYgGHgoCmtxhxL+zdKxAJeGhHkX9JgVXb789xBO6ATkz276vmlg9GFpuQdnoJ
VYSRkI395fTXURxLMUB3wwsMB15v9iFharvba0aaE7vKC6cxw8s=
=ZA/u
-----END PGP SIGNATURE-----

--YzlsFT6RVvAij316--