Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 11 Dec 2023 18:44:46 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Adding facility for injection points (or probe points?) for more
 advanced tests
Message-ID: <ZXbaDg5fBl8GLy2u@paquier.xyz>
References: <ZTiV8tn_MIb_H2rE@paquier.xyz>
 <CAExHW5vZXq8WiTFiCfzk-f7Sqi+TMZ0Ty6XxehUZ9o91GP_AJA@mail.gmail.com>
 <ZVwHHFCHC6PvV14o@paquier.xyz>
 <CAExHW5skzA6UPEYALz4GkCZdJZBt94uWahp5fExu09S90e1iHQ@mail.gmail.com>
 <ZWACtHPetBFIvP61@paquier.xyz>
 <CAExHW5usVs10M4i5RD68r5fpbr3mdzePnT589nT4X3cm7L64sQ@mail.gmail.com>
 <ZWCuG1GpB0bi49kk@paquier.xyz>
 <CAExHW5vyURNaht1YYJfZMk-Kyh=TD6FhE4NEi5zTAhnOj0qwcA@mail.gmail.com>
 <ZWUaACRWoH4WddLY@paquier.xyz>
 <CAFiTN-u+xrjmgK+3-TCjug_kqwWwUB3CXiOVjXNE1=vcf4JRUQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="7H6D6ExeKmpLmjzv"
Content-Disposition: inline
In-Reply-To: <CAFiTN-u+xrjmgK+3-TCjug_kqwWwUB3CXiOVjXNE1=vcf4JRUQ@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZXbaDg5fBl8GLy2u%40paquier.xyz>
Precedence: bulk


--7H6D6ExeKmpLmjzv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Dec 11, 2023 at 11:09:45AM +0530, Dilip Kumar wrote:
> I haven't specifically done a review or testing of this patch, but I
> have used this for testing the CLOG group update code with my
> SLRU-specific changes and I found it quite helpful to test some of the
> concurrent areas where you need to stop processing somewhere in the
> middle of the code and testing that area without this kind of
> injection point framework is really difficult or may not be even
> possible.  We wanted to test the case of clog group update where we
> can get multiple processes added to a single group and get the xid
> status updated by the group leader, you can refer to my test in that
> thread[1] (the last patch test_group_commit.patch is using this
> framework for testing).

Could you be more specific?  test_group_commit.patch includes this
line but there is nothing specific about this injection point getting
used in a test or a callback assigned to it:
./test_group_commit.patch:+	INJECTION_POINT("ClogGroupCommit");

> Overall I feel this framework is quite useful
> and easy to use as well.

Cool, thanks.
--
Michael

--7H6D6ExeKmpLmjzv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmV22g4ACgkQnvQgOdby
QH2s3A//VL7TCt3/6gzLFuKThzbsAqdIYMVxL7TOSfbzc0rwNgbuHVnC3xqAMS7X
LBcGsG9gwtR2CypMZDbdSSV1bSLWfxsawflsJmSYZPrVA+2psBBM98s+/extIEfX
DElgE0huntVn19p/oiEVy51RPayGVeYIqlzgHguGfu4XqhCygnqe6bFMk+LH6N8O
J3k9CNj1PA6vCApubLZALuCf4lOk6uRJH7lMVx0Za2UxN+gm+qfJEQcIgm8iLcBv
uYZ3CFCgkhrfeAhEqErO0EpObPkBnMyzwFEoFxjTzIA+xhKjLrqUtF5O89KSTjuN
PTPu1JWeXAP4g0tsYjUs63H2rApfObJAk61f6qi1GksPcdEQ7SiRJY1roTIMjd/s
GzD9NepCdDOWcZieaaW7ipqIlRi9EeNXFdEsBTVGXjI8qtgZm+Iub6jOOvekS94F
9L5e5VnjwBpaLpdAxrMfjpzaWeAUdaFgnv67mdaBPzQcixZosMwzuh8tIiW8U5/6
9UYeAcIoVORN+xFIBxig8kU0au5RQtLcPe5sfib6gfOnrsNcgnAM58XkidhvFJDS
7HBTdM5kIGX/nBHSlYtW4rA7SXn88WsOxI1WPA647x5Aozv5t2idv2sld/y8T7e4
8fpLD+qntSsI5GRUqLaWeVQAFHiVszO56aZ1D2n/zzUirEQnaFI=
=m3QD
-----END PGP SIGNATURE-----

--7H6D6ExeKmpLmjzv--