Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 11 Dec 2023 11:00:07 +0100
From: Michael Paquier <michael@paquier.xyz>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Peter Eisentraut <peter@eisentraut.org>,
	Nathan Bossart <nathandbossart@gmail.com>,
	Laurenz Albe <laurenz.albe@cybertec.at>,
	Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: GUC names in messages
Message-ID: <ZXbdpy7whLILt04A@paquier.xyz>
References: <CAHut+Ps3Lbo=hGevYf8AyjFo8+=SSwXUo7onB-6nS6e-Q-bQoQ@mail.gmail.com>
 <202312081255.wlsfmhe2sri7@alvherre.pgsql>
 <CAHut+Pu5Yh8xdAZUfvTxBMZZ6CcucgWTHvvazDgkBPB5RuiOuA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="diMNQzzjGuNphLgp"
Content-Disposition: inline
In-Reply-To: <CAHut+Pu5Yh8xdAZUfvTxBMZZ6CcucgWTHvvazDgkBPB5RuiOuA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZXbdpy7whLILt04A%40paquier.xyz>
Precedence: bulk


--diMNQzzjGuNphLgp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Dec 11, 2023 at 10:14:11AM +1100, Peter Smith wrote:
> This v5* looks good to me, except it will need some further
> modification if PeterE's suggestion [1] to keep quotes for the
> MixedCase GUCs is adopted.

-                errdetail("The database cluster was initialized with CATALOG_VERSION_NO %d,"
-                          " but the server was compiled with CATALOG_VERSION_NO %d.",
-                          ControlFile->catalog_version_no, CATALOG_VERSION_NO),
+                /*- translator: %s is a variable name and %d is its value */
+                errdetail("The database cluster was initialized with %s %d,"
+                          " but the server was compiled with %s %d.",
+                          "CATALOG_VERSION_NO",

Good point.  There are a lot of strings that can be shaved from the
translations here.

src/backend/access/transam/xlog.c:               errdetail("The database cluster was initialized with PG_CONTROL_VERSION %d (0x%08x),"
src/backend/access/transam/xlog.c:               errdetail("The database cluster was initialized with PG_CONTROL_VERSION %d,"
src/backend/access/transam/xlog.c:               errdetail("The database cluster was initialized without USE_FLOAT8_BYVAL"
src/backend/access/transam/xlog.c:               errdetail("The database cluster was initialized with USE_FLOAT8_BYVAL"

I think that you should apply the same conversion for these ones.
There is no gain with the 1st and 3rd ones, but the 2nd and 4th one
can be grouped together.

FWIW, if we don't convert MixedCase GUCs to become mixedcase, I don't
think that there is any need to apply quotes to them because they
don't really look like natural English words.  That's as far as my
opinion goes, so feel free to ignore me if the consensus is different.
--
Michael

--diMNQzzjGuNphLgp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmV23acACgkQnvQgOdby
QH39ug/9GaHxWzzZK08y+SYRqZXmq5Yg08/KHhnwzKXNw2N2BXC6XNLyKzW8lOoq
cKCLhIyJRD5dY2vXDeFgBtV7ktC4S406IoYTu1xHQy/MosuWGuYE2y8E4P0aLF+t
F7W+sj1uqi3hTZRoLMBgkzCSEVmfc+GPSlY63K0ioE0+JNbXk9W2tCyVrtMhtmH0
Tzft6IKMWF9m4vFJt2W2wHMLtMLwQLV5vD8T9SqJ+pdJOIHAd+tD1y/Lt+a+3xDz
PzYR9eG2+yXeWGG3mBl8T6yk1Z/Liq5KspxVJVjlbswj1SKI55ibDimCVZ2/jcoU
dwdPIW540TSqsgETnW348K/2eLxseYioMDm0Jbgpq91EthdmKY68lfFbQtmFrOm3
O+5k5SmGAi05W4NbDPsCmZmTBcC2BKtXLlDAv2Gxwcf4OkrG93LUaDrfmjrssqTZ
CeXc58BhTc7ibC6uSuXl4XopWTbP/WEqtxPVKnQrwAlqaXd/LJW8nWcR9WoGtTCI
qgvpJ4K4Kml+ZjrfCjJ+MGp36HG/TRA4hWiP+91rrR8QY1d5jOgVSln3wC2BqUZX
Smhr0xhMtgRFRNOB/TBh2ulvLvzwYw93VYmN8Q79cj/bZzsVtKSEm5bo6PsInedn
c47QedREeVsmODZACTJuzP0sa+ircivHzAXRDuys4N7mpilben0=
=vGXs
-----END PGP SIGNATURE-----

--diMNQzzjGuNphLgp--