Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFj5x-00BgRq-4g for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Dec 2023 23:01:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rFj4v-005wjv-0I for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Dec 2023 23:00:45 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFj4t-005wiL-El for pgsql-hackers@lists.postgresql.org; Tue, 19 Dec 2023 23:00:44 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFj4o-00BEtl-AF for pgsql-hackers@lists.postgresql.org; Tue, 19 Dec 2023 23:00:41 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 3ECAC3200AA4; Tue, 19 Dec 2023 18:00:35 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 19 Dec 2023 18:00:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1703026834; x=1703113234; bh=wza9tG0EcD qAqOZLWWfMqMApzr/ri9xCBaX0qbETeZE=; b=YCFIiOkxM/mc3ixVpym0eIKmzo B+Nr59ixNd7fEzpZaSHXbslgPqlhkgj19NvkYKig+k7fviJ3bHttIqWj2Fj6dbLM ZefEs/RvUepc/VN0XdKMakCP/2mnuNwNKp/fsPCzltCrJgvmE5jZ03f7qacuNPR5 ztG5GIMg6OSSE4UOpuHa38vTDsqZsLoL6j5I7ibQANgScPiE3e5qp0pG05JdP12h ygMu4ROJADzgQ/I4zjt3i2S8WuksM/aSgG5AT7/NG6O9CpafRWcUKH5qP0Muzube QpZRJn75Pgu1hU1B3kGUk5pvY3N9eqtFkR/cBEE35GvcnRjbLzPEKWfDfRrw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1703026834; x=1703113234; bh=wza9tG0EcDqAqOZLWWfMqMApzr/r i9xCBaX0qbETeZE=; b=t+BqnBlICVZ7ZyrL1dIlGMtDSkhJp6/XUz4Lv7s8/fMB V2JWyVEyDdIi0cwmBr4Gpj/H4r3eOZJancTBJd3s2ZY0aPAiWUqXoWP3+bGRwONm Q8v5a0CgKlzTGDOJMekn7kYzZZBa7ZPiYlSpZHmXubF3ENmFaIw8Fjpumy5UXTqy FyLAsaJI7UDPmXA9ERNlX8J9PI5sJywJbhKLyCrBk4fm4oPun25aMUEnv679GEuu qHUH5PubnL/ZShku6C677D2V/WSRsk5MWE+tUR6JU+R0Y02bFWqcGRQ0vDboPRcm 6AWpG4idertlSQxsyOv5MmlzPT23oD9EPJmZf5bd6A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdduuddgtdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Dec 2023 18:00:32 -0500 (EST) Date: Wed, 20 Dec 2023 08:00:19 +0900 From: Michael Paquier To: Bharath Rupireddy Cc: Euler Taveira , Kyotaro Horiguchi , Alvaro Herrera , Andrew Dunstan , pgsql-hackers@lists.postgresql.org Subject: Re: Add a perl function in Cluster.pm to generate WAL Message-ID: References: <20230615.134015.1421242753635015365.horikyota.ntt@gmail.com> <3a6978d6-e4fc-4014-b5f7-45db53d8fa53@app.fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vrvJTH/R2fwU1Lwj" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --vrvJTH/R2fwU1Lwj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 19, 2023 at 11:25:50AM +0530, Bharath Rupireddy wrote: > I used pg_logical_emit_message() in non-transactional mode without > needing an explicit WAL flush as the pg_switch_wal() does a WAL flush > at the end [1]. Indeed, that should be enough to answer my comment. > Attached v4 patch. LGTM, thanks. Euler, what do you think? -- Michael --vrvJTH/R2fwU1Lwj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmWCIIMACgkQnvQgOdby QH0G7A/+OGXCNycXJ6g1WuTIvNKd1cTlRnjsUVSaQFnb2LdJmHBrXv5VQYKvn3Bo WoOfpohh2wabc4TGmSSFHc6raMeUPawYcFsfWfpLNXpLTk9k+zioYJeJPwI7XDRP 63eOrNrOlHcgkvd9H+twfadeKoVwaDwrFX1iZA1O6namSHd4I0tI0I5mB+5wliD2 gxtAmG4kKUZ6hyYs3D76s0bdj1IF7FYlUspddK6WV8uZHqjhxU/c2eyChraVXH6J d8Zn2fKvHMM5wez4MfzGBroClgWS9xjrxgN0lAJ5ctWt31uzCNoWkJ0jatzdhnHb HyULPYGvbsIASqSWQQ8+Ek65UJmKlZF8RapC0dEq9WoZ14IgpYmpc409gTSF3lQ0 BIwbz2yJ7sy/c1RA6BnswLEcX3cBHAJMdOxHkyMmNf9VpJpa6kLSmpaTeY8NrMoN yEiWNjPPy8n2t8GvhWbZZVJtUMNhUtza11fR9+Hj4QaaOFcFb5jmLfNzqhrdoW+a R7J69cCQm+svzr6xJvWDg3tMeU9EainUdFiawjjcUbqQHIVifE/66dPKd3lDXo+n vs9Hn+H0wamEuQEpnLVGpY5uf29rPpugwmel78ogZe0/1ovAnvDmK4GtYSvjmquC WfEFnsAp9fYXjJiTPHgzJ/DlcjpGZ7doDMGjbd42zKrEljC7ieI= =uzDJ -----END PGP SIGNATURE----- --vrvJTH/R2fwU1Lwj--