Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 21 Dec 2023 10:21:45 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Euler Taveira <euler@eulerto.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Andrew Dunstan <andrew@dunslane.net>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Add a perl function in Cluster.pm to generate WAL
Message-ID: <ZYOTKV1MV7gDYpCV@paquier.xyz>
References: <CALj2ACU3R8QFCvDewHCMKjgb2w_-CMCyd6DAK=Jb-af14da5eg@mail.gmail.com>
 <20230615.134015.1421242753635015365.horikyota.ntt@gmail.com>
 <ZIvJN/VVQUn6nb8p@paquier.xyz>
 <CALj2ACUkXXsCTNoqhTr=S-CV7qdCB=QEiMvuuo31brLkLz4o6w@mail.gmail.com>
 <CALj2ACXR7FkdvzK1XaansV05awGnaCH82yu9M4gBiCueU_0GSA@mail.gmail.com>
 <3a6978d6-e4fc-4014-b5f7-45db53d8fa53@app.fastmail.com>
 <ZYEaLlhZ5lgTqsaQ@paquier.xyz>
 <CALj2ACXppTLS1pKa=M-h-VxWHSTo4iJvHYik_J+pLQxdeLMAzQ@mail.gmail.com>
 <ZYIgg55UyDS56Y9l@paquier.xyz>
 <5d160064-8cbe-4b32-9c55-c983b1f63b12@app.fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="o18LuzQUAwi9Qa/W"
Content-Disposition: inline
In-Reply-To: <5d160064-8cbe-4b32-9c55-c983b1f63b12@app.fastmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZYOTKV1MV7gDYpCV%40paquier.xyz>
Precedence: bulk


--o18LuzQUAwi9Qa/W
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 20, 2023 at 12:24:04AM -0300, Euler Taveira wrote:
> LGTM.

I was eyeing at 020_messages.pl and it has a pg_switch_wal() after a
transaction rollbacked.  020_archive_status.pl creates a table, does=20
one segment switch, then a checkpoint (table is used afterwards).
Perhaps these could be changed with the new routine, but it does not
seem like this improves the readability of the tests, either, contrary
to the ones updated here where a fake table is created to force some
records.  What do you think?

We have a few more pg_switch_wal() calls, as well, but these rely on
WAL being already generated beforehand.

I have added a comment about pg_logical_emit_message() being in
non-transactional mode and the flush implied by pg_switch_wal() as
that's important, edited a bit the whole, then applied the patch.
--
Michael

--o18LuzQUAwi9Qa/W
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmWDkygACgkQnvQgOdby
QH1uGw/+Igw3cvxuwin5InqTEAmX+L+txMLmmqEbsjb2YbhN7kNnj2PFJaiL3BSr
1Ul9D5dtQ0jlivVWC0QttJv5xguMEswuEFKjjYVU2CZ9uz2L6yt8HqEq8R7+Amoc
3D5TSMF8AUPcWG42RLEyiymNeNrqc9bFlX0wY89kGiOaGNoEK8rKrxk8ZnS7dqvl
jEsgmKurvNraQu6MsI9yYR9KYF2kvw4chAqLL3GAmDPxWUyWavZhIcrwq9YTTcHV
sgQg3fl5mM1vuhcughe74NZIk7TmbGjaAw2sgFHavqSYSI2hAcAyYhcE6PU1TDHO
zrmHKVx8wQl9/6O6QqZBDxyIXmX0SEYMc/D3lBdsZWidP9wdWR3BaCiOr1q4b63m
FqoeWhqSSrKiHzyZm5+oSqUor4sxN7CDsWvsKZL/hZsb9yne+TriUUbDKSWgB6cc
Jqwim2h0LJxLSFZ3wih7Pj4tzldB+gACMDyo+StD4vqgW0yFnWxNkEmWZd8l1eZQ
6r2TwVwj7hsw9HephzG3zE62nGlK+0jE0sonDHInpwf/JD4OSYPedhKDiKWtKVKO
xGDLWoGyV9T/gpBKpZT8FY8KrhWz4lxzInDsAvU+xi2eTJXcDC4Sm+cmAle0HHB+
uPeRCxDqGLayUIXXIdDwR0tzbTkhzcnIeAykhQKHvPr6er9c5jM=
=dggu
-----END PGP SIGNATURE-----

--o18LuzQUAwi9Qa/W--