Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rKr5o-004ocl-TW for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Jan 2024 02:34:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rKr5j-002gI5-Tb for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Jan 2024 02:34:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rKr5i-002gHi-C0 for pgsql-hackers@lists.postgresql.org; Wed, 03 Jan 2024 02:34:47 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rKr5Z-00DStv-2W for pgsql-hackers@postgresql.org; Wed, 03 Jan 2024 02:34:43 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id C61AB5C017F; Tue, 2 Jan 2024 21:34:35 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 02 Jan 2024 21:34:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1704249275; x=1704335675; bh=so/44ECr9l lcf2qmD+MlIqHUAR8JSUikIHM0lARK/Ag=; b=X4utTpwHBdlTws8UxCz3aTx3t+ ep64l7y8OIOE5GZlizDKhinPRMjFEcXHGfz2Cf37J5+8AtessLLVptxU/IPJyBb0 WaQGOhHS8b0na1XBocAxVR+0r2S8NfRMPcWs5pdDgBcIFD+z48ri7azNgYTeiHXE YDmq9UV65C7v9gRJY6R26TwEBqn3kaf55jWi7xUZz3L5cXdH1DnBWOxWTmCXql6Q G6vPGOGzSlrNlVgykAYDVk1yeAHq2qynTthbN032LNbzJ0s8KiyHZFmEILWgS5yf SszMq82l0CB6z4UkkBuyGy0JACQqwKSViwQeOdU1+Eg5rcQPCb24W54YLt3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1704249275; x=1704335675; bh=so/44ECr9llcf2qmD+MlIqHUAR8J SUikIHM0lARK/Ag=; b=spsYHeVN/tKZamTaNc5FhLkytvGwNRWUOukNWgokZHH4 OrINGeuPFhD7rJxAxQ0bp7qBtj96Liz5NhktGYUjsRfx/nnuTiXYulSM4Q1vkFRd vrnwt+4LksddfOBCgKdWjfrYPYu6au1naJgE3Zo2JfhBTncdlx2YwG6e/JEHIBKc w7KKeNC0L2en0OaP3jPJ86lTrvwVXHXLqsmefLxdR67/SNaEnNNIv3/jb9/nQak3 WHzpItQOpY9nVPkQbbD6YDCGKp27u+7LSDkH9cQYGLQzT15/9RXiH3nqBI3jgVCl yd+/DPpwng3iwqnK5ZjJt05TACIe5PTl24n4vAgv1g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeggedggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 2 Jan 2024 21:34:34 -0500 (EST) Date: Wed, 3 Jan 2024 11:34:25 +0900 From: Michael Paquier To: Nathan Bossart Cc: Robert Haas , "pgsql-hackers@postgresql.org" Subject: Re: verify predefined LWLocks have entries in wait_event_names.txt Message-ID: References: <20240102173120.GA1061678@nathanxps13> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9y3A1rhvpW5ZiOPS" Content-Disposition: inline In-Reply-To: <20240102173120.GA1061678@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --9y3A1rhvpW5ZiOPS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 02, 2024 at 11:31:20AM -0600, Nathan Bossart wrote: > +# Find the location of lwlocknames.h. > +my $include_dir = $node->config_data('--includedir'); > +my $lwlocknames_file = "$include_dir/server/storage/lwlocknames.h"; I am afraid that this is incorrect because an installation could decide to install server-side headers in a different path than $include/server/. Using --includedir-server would be the correct answer, appending "storage/lwlocknames.h" to the path retrieved from pg_config. -- Michael --9y3A1rhvpW5ZiOPS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmWUx7EACgkQnvQgOdby QH2jURAAmBXSwrjuqzOCD5tMfDOPIjEK+gDS2SfuT9JR8KNAtsJ3UeiOdv6EvotQ vwHYkLLmAxsDe5PkEfZl/rhaL6ixfFPpOcrL/Ijfl26E4CGZzLxiQOwF5Mc9soUm z36zQABdtcxBPv01DR2Xrn1KYnrtuUQv7o4OEkZD+GyNboa04eC20Mk+HfqCckM7 PiDlFNqeDU0+oMmLmwSBmb3Mjdg/cpEZfunN2eeK5cH8UTJdFto7w19vNY/AYfyE 43/h6c49EZ9qA/IOFSeHIVbGedcIJkeZxhnenaMWFwMeFQoA48fZzFv/bX7tIdtX BTdc39HzvQFe9tWd4HxRxCZCB4Yo8++oQF8VSqcX5eQCCaWzGRQ7Xt3TIa4hVNIG NaTUD7iPeUFXeRbq7MqzPfEN+QkmAhbCGV+SYnDsvCLoOb8oWciH+Plh5HSbELf/ DG1SdePxOnNzlfbduT+n8z4WvuScaI6nN+J/As4B7AoWtexU1atxJG5joOwCORA2 5aQpmp7knMRgPIugsUBFGrDS+q9+Rj3kYIBwDgMplphEpGS3tlzfRTF+Sm2mXLso eyD7A0RHWfuYvPzZJ480RaNQANobClj7tgRK0znZxyJSNyawlPr/lMnjw5zoCgJe BkljR+d1pCAiouBYYDYHczzmuB5bTgQDExN2IR4GHcfvi7l8dCU= =0wv+ -----END PGP SIGNATURE----- --9y3A1rhvpW5ZiOPS--