Date: Sun, 7 Jan 2024 07:27:00 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: pgsql-hackers@lists.postgresql.org
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Cary Huang <cary.huang@highgo.ca>,
	Maciek Sakrejda <m.sakrejda@gmail.com>,
	Shubham Khanna <khannashubham1197@gmail.com>
Subject: Re: warn if GUC set to an invalid shared library
Message-ID: <ZZqmpB8a0CokcxwC@pryzbyj2023>
References: <20220722183557.GC7789@telsasoft.com>
 <729940.1658516423@sss.pgh.pa.us>
 <20220722191443.GE7789@telsasoft.com>
 <734432.1658518007@sss.pgh.pa.us>
 <20220902222458.GC31833@telsasoft.com>
 <20221029174053.GA19704@telsasoft.com>
 <CAOtHd0DXpECx=w556LQQQyMG7bRKSStsr=wyF=5PN3TBAW3nCg@mail.gmail.com>
 <20221031133120.GO16921@telsasoft.com>
 <20221101222634.GE16921@telsasoft.com>
 <ZKcg1w4FoYq/4M4V@telsasoft.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="E4B85hAaG7CiJkTa"
Content-Disposition: inline
In-Reply-To: <ZKcg1w4FoYq/4M4V@telsasoft.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZZqmpB8a0CokcxwC%40pryzbyj2023>
Precedence: bulk


--E4B85hAaG7CiJkTa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jul 22, 2022 at 03:26:47PM -0400, Tom Lane wrote:
> Hmph.  I wonder if we shouldn't change that, because it's a lie.
> The value isn't actually coming from the config file, at least
> not yet.

On Thu, Jul 06, 2023 at 03:15:20PM -0500, Justin Pryzby wrote:
> On Sat, Oct 29, 2022 at 10:40 AM Justin Pryzby <pryzby@telsasoft.com> wrote:
> > > > > On Fri, Sep 02, 2022 at 05:24:58PM -0500, Justin Pryzby wrote:
> > > > > > It caused no issue when I changed:
> > > > > >
> > > > > >                         /* Check that it's acceptable for the indicated parameter */
> > > > > >                         if (!parse_and_validate_value(record, name, value,
> > > > > > -                                                     PGC_S_FILE, ERROR,
> > > > > > +                                                     PGC_S_TEST, ERROR,
> > > > > >                                                       &newval, &newextra))
> > > > > >
> > > > > > I'm not sure where to go from here.
> > > > >
> > > > > I'm hoping for some guidance ; this simple change may be naive, but I'm not
> > > > > sure what a wider change would look like.
> 
> I'm still hoping.

@cfbot: rebased

--E4B85hAaG7CiJkTa
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v8-0001-WIP-test-GUCs-from-ALTER-SYSTEM-as-PGC_S_TEST-not.patch"