Date: Tue, 15 Apr 2025 20:57:32 +0200
From: Christoph Berg <myon@debian.org>
To: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: Peter Eisentraut <peter@eisentraut.org>,
	Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
	Bruce Momjian <bruce@momjian.us>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
	Daniel Gustafsson <daniel@yesql.se>,
	Thomas Munro <thomas.munro@gmail.com>,
	Nazir Bilal Yavuz <byavuz81@gmail.com>,
	Antonin Houska <ah@cybertec.at>,
	Wolfgang Walther <walther@technowledgy.de>,
	Jelte Fennema-Nio <postgres@jeltef.nl>
Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER
Message-ID: <Z_6sHOSFBecBLJtv@msg.df7cb.de>
Mail-Followup-To: Christoph Berg <myon@debian.org>,
	Jacob Champion <jacob.champion@enterprisedb.com>,
	Peter Eisentraut <peter@eisentraut.org>,
	Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
	Bruce Momjian <bruce@momjian.us>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
	Daniel Gustafsson <daniel@yesql.se>,
	Thomas Munro <thomas.munro@gmail.com>,
	Nazir Bilal Yavuz <byavuz81@gmail.com>,
	Antonin Houska <ah@cybertec.at>,
	Wolfgang Walther <walther@technowledgy.de>,
	Jelte Fennema-Nio <postgres@jeltef.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAOYmi+=8T_rDi3SnnPOqG0h5SP8og1d1KnkHpHLDuj3gtm=cHA@mail.gmail.com>
 <CAOYmi+=2cArQoSSRdAYwx2TBSHL5r0UhX28Q-5TP=0g-sxBXCA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Z_6sHOSFBecBLJtv%40msg.df7cb.de>
Precedence: bulk

Re: Jacob Champion
> But there's no connection between "libcurl" and "OAuth Device
> Authorization flow" in anyone's mind except the people who have worked
> on that feature.

Fwiw that was exactly the reason I originally voiced the idea to
rename.

> But let me turn this around, because we currently have the opposite
> problem: if someone comes in and adds a completely new feature
> depending on libcurl, and you want OAuth but you do not want that new
> feature -- or vice-versa -- what do you do? In other words, what if
> your concern is not with libcurl, but with the feature itself?

What made me reconsider was Peter saying that what defines the blast
radius of some feature is usually the extra dependency pulled in. If
you don't like tracking OpenSSL problems, build without it. If you
don't like libcurl, build without it. That's the "we are going to be
hated by security scanner people" argument that brought up this
sub-thread.

Now if the feature itself were a problem, that might change how
configuration should be working. Is "libpq can now initiate oauth
requests" something people would like to be able to control?


Re: Jacob Champion
> Dynamic: --with-libcurl builds a runtime-loadable module, and if you
> don't install it, OAuth isn't supported (i.e. it's optional)

Ok.

> Static: --with-libcurl builds an additional linkable staticlib, which
> you must link into your application (i.e. not optional)

Debian does not care really about static libs. We are currently
shipping libpq.a, but if it breaks in any funny way, we might as well
remove it.

Christoph