Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u0pK2-008fTj-2n for pgsql-hackers@arkaria.postgresql.org; Fri, 04 Apr 2025 22:15:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1u0pJz-005eER-QY for pgsql-hackers@arkaria.postgresql.org; Fri, 04 Apr 2025 22:15:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u0pJz-005eEJ-Gb for pgsql-hackers@lists.postgresql.org; Fri, 04 Apr 2025 22:15:31 +0000 Received: from mail-yw1-x112b.google.com ([2607:f8b0:4864:20::112b]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1u0pJx-003R7v-0e for pgsql-hackers@lists.postgresql.org; Fri, 04 Apr 2025 22:15:31 +0000 Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-6feab7c5f96so25010737b3.3 for ; Fri, 04 Apr 2025 15:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743804928; x=1744409728; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=u6hm9CxfUlHlwwjrbtmBysL6q9QJin+XMYRUTrKFGV4=; b=gSJgBwarECb98rgcqz9c0QmDp/BfUjJyk+K3R+BIBxALLuo9OSgvUmH+bvVn18KKZj sy/pB5UOMsC2ywvLyQJy6FxqrfYwe0VP6pDkG0y0Nkp/DrzM1LCr2PBlyTqDVJN/mUia I/qJ7ZUroQrVVqElAdrpYKtYQj2rW8RZ/eQzc+83/NHFIlMqC8VR1dFdpIwngeSgn79Z 1tgoMBc3ToFQhMnSCxqJupxyxtsDbmTVo6ctEDtGmDhubnJolZ6dSaj9b2j2TeGBjCEd 5B90/xev9QwiSlj6ATTO8ZDGjxOWVjopbtMO4NSWqFJJ8IVG7OM5EC1Fx6+mU4s084BC agWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743804928; x=1744409728; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=u6hm9CxfUlHlwwjrbtmBysL6q9QJin+XMYRUTrKFGV4=; b=ihuTP+jbINCCPcI+Pf5AkgF2OiXXB3JGHAMnlZv6V9jT9Mnc0BymXpf6NG7Usfi5TT sdGBh4JGJ66afxMolEm0nlMvismfWWIKIlKuDrRqkcV9rVby/TzyxwcOyuLf4w9Xs7MK dBa60Lc6PmCqiXPCgwoMlSyQhuXb4ICDYCd4/MEIJ9uy2LX09CFLXXiGjAV1o5IpsEPO O4K7nCXpVzNFcyyL7IVaHd7S8F9rWEdsLX4O/i2lhWB/d85QxyJzFjeNTojHiIIXdb6k kZWr2apGNdzIdJDq/AFvWXz9SrkTQ3WuPrBDthW7HetwXRfD/DjE+5tKUMmVKAJ1MOjO 8w6A== X-Forwarded-Encrypted: i=1; AJvYcCUVhtZgPQnIgaYHaJY+/33aThDa38Wf13Z/5fFPrd/we9+Wif6h+SeEcK6qvr7Dbu/LBysuEOVodkaFHA5m@lists.postgresql.org X-Gm-Message-State: AOJu0YysiMbye9cPf4R5YKHCFrY1JR0yNLG40rg9CNqZnazoxFeOI7Nu cKvASQOicxddqsr+Y1kFXN6GMOK0Zp3BDtmd/D/LGQYuZuNGbAmF X-Gm-Gg: ASbGncvbve8NLaxYO/aymrOMFt6UctE8v3JT4p/OcBXrRvRHcWOjejWFxpcEyOOWIDD tMSSCMpFZ32ucmqnwELNrIkR6tz1IpiDgvMrtZUiAX2XzLSyQtOh2vzWxHEazFJm7iNMKZJCusH ymeSU1gjRDdMCqCb+zx312uhwlMJsKgGH2YIvNXpIvZoO3x4o7aFrU28M3LaNsE0T7ukXZRyTJQ RAXqM9R7D4vp9sg1RghmpK923/Rr7x1TuWTL2OctVr04MEr40rWgoVjwPYpIaulJAK0mhkaJVEx IZcGsn/WLMSMRNcWzfwh7dq1JTnuBHn/EDHul6t2jYAFVrFpb1ZRwSWhbzi6GDrU1uFqKv/VbGv iAiqrjJAG/38sS5ySPaUXuOMUC+qhl+9qQwM= X-Google-Smtp-Source: AGHT+IEaRXFu+76x92PKilHvHwO4hyHiMXKa5FZyZF8ELzHaRqhdNTwGndO1TW+wUt1IDio4TuzPCw== X-Received: by 2002:a05:690c:61c4:b0:6f9:7fe6:9d48 with SMTP id 00721157ae682-703e150062emr77056527b3.7.1743804927768; Fri, 04 Apr 2025 15:15:27 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 00721157ae682-703d1fa6f24sm11035297b3.98.2025.04.04.15.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Apr 2025 15:15:27 -0700 (PDT) Date: Fri, 4 Apr 2025 17:15:25 -0500 From: Nathan Bossart To: John Naylor Cc: "Devulapalli, Raghuveer" , "pgsql-hackers@lists.postgresql.org" , "Shankaran, Akash" Subject: Re: Improve CRC32C performance on SSE4.2 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Apr 02, 2025 at 02:10:40PM +0700, John Naylor wrote: > Thanks for looking, I plan to commit this over the weekend unless > there are objections. I noticed that autoconf is defining USE_AVX512_CRC_WITH_RUNTIME_CHECK, but everywhere else expects USE_AVX512_CRC32C_WITH_RUNTIME_CHECK (with the "32C" included). I tested the v16 patches (with the macro fixed and assertions enabled) on a machine with AVX-512 (verified with some extra debug logging), and everything passed. -- nathan