Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 5 Apr 2025 19:14:27 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Noah Misch <noah@leadboat.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	Robert Pang <robertpang@google.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, robertmhaas@gmail.com,
	pgsql-hackers@postgresql.org
Subject: Re: Back-patch of: avoid multiple hard links to same WAL file after
 a crash
Message-ID: <Z_ECg-lN2xQbqkLc@paquier.xyz>
References: <Z2L6e1w-xABVTBRR@nathan>
 <7chjz7zeigbsbt7nim4cj6zryflzcpy2lgenas3yh7cpvwf3gb@m6cwqzlvfd6q>
 <Z2Oy1Z2nMVmTM5L5@paquier.xyz>
 <20250306193013.36.nmisch@google.com>
 <Z8n7HopB0bb4_j19@nathan>
 <Z853yPDh1xNWssD_@paquier.xyz>
 <20250311205749.a8.nmisch@google.com>
 <Z9DZY8PVgXI3-b5j@paquier.xyz>
 <20250312012315.fd.nmisch@google.com>
 <20250403002900.5d.nmisch@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="5PkcAJ9+zX6MICLZ"
Content-Disposition: inline
In-Reply-To: <20250403002900.5d.nmisch@google.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Z_ECg-lN2xQbqkLc%40paquier.xyz>
Precedence: bulk


--5PkcAJ9+zX6MICLZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Apr 02, 2025 at 05:29:00PM -0700, Noah Misch wrote:
> Your back-patches are correct.  Thanks.

Thanks for double-checking.  I'll move on with what I have after a
second look as it's been a few weeks since I've looked at all these
conflicts.  I am also planning to add a few notes in the commits to
mention this thread.

> Here it is.  Making it fail three times took looping 1383s, 5841s, and 2594s.
> Hence, it couldn't be expected to catch the regression before commit, but it
> would have made sufficient buildfarm and CI noise in the day after commit.

Hmm.  Not much of a fan of the addition of a test that has less than
1% of reproducibility for the problem, even if it's good to see that
this can be made portable to run down to v13.
--
Michael

--5PkcAJ9+zX6MICLZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmfxAoMACgkQnvQgOdby
QH0HVQ//XWTd3pYIkn43BkxgJqRvEqh+aKCV+KuC6QUZ8PAbVRSEosfnx8lqfbfq
vs26DN/wiYy5CyR5GXHF4EfHzh6zjponjfCKrXU4DhHFeL8DC9zrrQaoUhvUSGTG
hsymT6TNeuRZ2vLjdfKV+mJ4zcw0hny6uJvhHT3MLcXjF7KZw5FqfOabzDlk62g1
zRL2RidriCj5zs8n2wZcm0GInkdhIWZyNtXwPIz85Wbx0SZpdFEGrJbwTm85VPo+
3UQAHJzxOe6buhpo49owmFPwHCa39/bhNeelICXn8qt8LxWizFzrZzhp/Eu3FkzM
a0ImGgHk/KzzGe1GupljTZP5K6aDXBDfOOX0oLZ9CNIXUM/TxkE1e1flaIHj7gds
7Kl2iZifBBO2/teABFDcM96rmKTQtB2xcrzvuXHKXsT7aaDuglY+wu4WClEK05Ip
h4m+QIiphUmhqaCefHRsn3eC5PZwF+6dRs9bl5XC219HUvIzhLMx7felomOOdJzX
27M1EPcttEDEmANwTVCr1q5+MbhuVdwRIA+ymOOWnhbu/YSBevj0x+Yta0NBFuJ1
rrdU4eUUpiDjx7YPC2zrgrYfMHCVHFhyGWP+2ivm+Rgy8RurmN+3ywPtznuS/rHf
C5YrvVtAwxaGX3zcTEjV/zF4Rco239xc7BuvoRAhpXEB4ZoqDLo=
=MyjM
-----END PGP SIGNATURE-----

--5PkcAJ9+zX6MICLZ--