Feedback-ID: i0fe9450f:Fastmail
Date: Sun, 6 Apr 2025 07:42:02 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Noah Misch <noah@leadboat.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Nathan Bossart <nathandbossart@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	Robert Pang <robertpang@google.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>, robertmhaas@gmail.com,
	pgsql-hackers@postgresql.org
Subject: Re: Back-patch of: avoid multiple hard links to same WAL file after
 a crash
Message-ID: <Z_GxukueQn7lDs1u@paquier.xyz>
References: <20250306193013.36.nmisch@google.com>
 <Z8n7HopB0bb4_j19@nathan>
 <Z853yPDh1xNWssD_@paquier.xyz>
 <20250311205749.a8.nmisch@google.com>
 <Z9DZY8PVgXI3-b5j@paquier.xyz>
 <20250312012315.fd.nmisch@google.com>
 <20250403002900.5d.nmisch@google.com>
 <Z_ECg-lN2xQbqkLc@paquier.xyz>
 <2461391.1743865633@sss.pgh.pa.us>
 <20250405191339.8d.nmisch@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ln66crX8qYZYLMo9"
Content-Disposition: inline
In-Reply-To: <20250405191339.8d.nmisch@google.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Z_GxukueQn7lDs1u%40paquier.xyz>
Precedence: bulk


--ln66crX8qYZYLMo9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Apr 05, 2025 at 12:13:39PM -0700, Noah Misch wrote:
> Since the 2025-02 releases made non-toy-size archive recoveries fail easi=
ly,
> that's not enough.  If the proposed 3-second test is the wrong thing, what
> instead?

I don't have a good idea about that in ~16, TBH, but I am sure to not
be a fan of the low reproducibility rate of this test as proposed.
It's not perfect, but as the design to fix the original race condition
has been introduced in v15, why not begin with a test in 17~ using
some injection points?  This should be good enough while having a good=20
reproduction rate as the order of the actions in the restart points
would be controlled.
--
Michael

--ln66crX8qYZYLMo9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmfxsboACgkQnvQgOdby
QH2vug//Yo4DOVW5Ghd3a8MswHBOtzITqj3MCJc+Qt1JdQM6lypNiu+zWuqTjUf9
C2iJikXq2Y08LI+0ZMQDds5eNiLuSeEBmfZUBihJ6N87Yr3TGt/je6emA/HOLmCx
06yXyOkZLLcHAOfHOY1E8QSCk7mbWFdBUM+NRSHeUXF8FSD2418M6olpP+LQhvLk
6xJIar++FZAIO9AkVfdG6xrWhqSzY5H2imL2ta1AEM2sBOayGdZEUhBnd0Uhl7N1
4yTAuXInqhytEiywPqgfOcZzwkhgQL2Jd7rgvyeWezQo3ggeOWL/W2DEj+KFysr3
j2rD43WHNkY3FOJzg3FtH5hVCT+oRK7c/9+EA1uo2KVRTE0RhS6/zsX0fNWeeqav
boKev4WuZxD9s22WVL7KQxD2sY4ANg/LL/sd7sD7vSbMfoheYm6t0W35Hg25oqEy
sGqD67vUyQ2E2iF2jax1CyIomwaiIV9HJalAfCm/Rh0BW8XmsrnIIM8wtDR6DxfE
4K9Vvv6Gnvt6+deTjJ8ZpGDcpbN0ZEpvlt/Lvqck4TPpy/UcvehNC7oX9f7YQkJk
yk0gcdwPafeZbqZuJKiU4J3evESTJtnwn9hXtVmrRF3dKshNAKGogSi2s40M2Q+2
r0jrjuM5u/gZvdVAyqdU+lBBIdvsFr2NXi4vuI3QrAuBakPHVlw=
=G0iU
-----END PGP SIGNATURE-----

--ln66crX8qYZYLMo9--