Date: Sun, 6 Apr 2025 09:50:00 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Mahendra Singh Thalor <mahi6run@gmail.com>,
	=?iso-8859-1?Q?=C1lvaro?= Herrera <alvherre@alvh.no-ip.org>,
	Srinath Reddy <srinath2133@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: getting "shell command argument contains a newline or carriage
 return:" error with pg_dumpall when db name have new line in double quote
Message-ID: <Z_KUmMRXzWtJZzfN@nathan>
References: <e3d80815-cf3e-4776-96b6-a7acc80fb495@dunslane.net>
 <202503271303.dsnq652h7e7d@alvherre.pgsql>
 <CAKYtNAoVKQL5rLD4P4hZXZSnThwO-j4q3Y1vTDHQGjzwC-kUJg@mail.gmail.com>
 <CAKYtNAqRJZMnt6WAZmpSkg3VMRGZtfz=zX3UZqJmkG3W=wE6fA@mail.gmail.com>
 <Z-a1m_eDU-yKlMWq@nathan>
 <1317bb5e-3251-42c3-8874-31fb400398f9@dunslane.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1317bb5e-3251-42c3-8874-31fb400398f9@dunslane.net>
Archived-At: <https://www.postgresql.org/message-id/Z_KUmMRXzWtJZzfN%40nathan>
Precedence: bulk

On Sun, Apr 06, 2025 at 10:24:58AM -0400, Andrew Dunstan wrote:
> On 2025-03-28 Fr 10:43 AM, Nathan Bossart wrote:
>> Taking a step back, are we sure that 1) this is the right place to do these
>> checks and 2) we shouldn't apply the same restrictions to all names?  I'm
>> wondering if it would be better to add these checks to the grammar instead
>> of trying to patch up all the various places they are used in the tree.
> 
> Maybe. I don't think there is time for that for v18, so we'd have to defer
> this for now. I can live with that - it's been like this for a long time.

+1, I think deferring is the right call.

-- 
nathan