Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 8 Apr 2025 14:13:20 +0900
From: Michael Paquier <michael@paquier.xyz>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: 'Amit Kapila' <amit.kapila16@gmail.com>,
	Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: Fix 035_standby_logical_decoding.pl race conditions
Message-ID: <Z_SwcA4GORIIObNS@paquier.xyz>
References: <Z+z3Hs765Ixo0mN7@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAA4eK1KvnWZtXh0p8MOnXdz7ts1iHJ0yjb-F3ejk3mGLV6v__A@mail.gmail.com>
 <OSCPR01MB1496631866E979BD510BC5448F5AF2@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <Z+1RJElgG/7H9n+v@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAA4eK1Krrie2X40qdj9Qu8D109DjjqS4nH-woJCheBtgdNyR_w@mail.gmail.com>
 <OSCPR01MB14966608F78B5BFC907CF8E82F5AE2@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <CAA4eK1Kd7Cxc=GBz58O_EX5xrQ5TzyNsHmqEtQNR9j=ox74u1w@mail.gmail.com>
 <OSCPR01MB149666E4ECE1C38C60E496EDCF5AE2@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <CAA4eK1KBiW+wBFiNgPjm5VyKXCKUQ8igkmf4rnS98=P3RnAukg@mail.gmail.com>
 <OSCPR01MB14966BE900F2F29594D5E1FE7F5B52@OSCPR01MB14966.jpnprd01.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="eJsYljpsSCzg3rJz"
Content-Disposition: inline
In-Reply-To: 
 <OSCPR01MB14966BE900F2F29594D5E1FE7F5B52@OSCPR01MB14966.jpnprd01.prod.outlook.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Z_SwcA4GORIIObNS%40paquier.xyz>
Precedence: bulk


--eJsYljpsSCzg3rJz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 08, 2025 at 02:00:35AM +0000, Hayato Kuroda (Fujitsu) wrote:
> Your patch looks good to me and it could pass on my env. PSA patches for =
PG16.
> Patch for PG17 is not changed, just renamed.

@@ -1287,6 +1288,17 @@ LogStandbySnapshot(void)
=20
     Assert(XLogStandbyInfoActive());
=20
+#ifdef USE_INJECTION_POINTS
+    if (IS_INJECTION_POINT_ATTACHED("skip-log-running-xacts"))
+    {
+        /*
+         * This record could move slot's xmin forward during decoding, lea=
ding
+         * to unpredictable results, so skip it when requested by the test.
+         */
+        return GetInsertRecPtr();
+    }
+#endif

I have unfortunately not been able to pay much attention to this
thread, but using an injection point as a trick to disable the
generation of these random standby snapshot records is an interesting
approach to stabilize the test, and it should make it faster as well.
Nice.
--
Michael

--eJsYljpsSCzg3rJz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmf0sHAACgkQnvQgOdby
QH185g//Rt41y1LuDtOb1Rn3tdU/WAX6ep79edLj/R089GfM9bAbvg6cMm3RjlPP
F+2aEjjT1FQPqEYqnFZItdpKdOfxFUZBDvil5xweG0q5wTjLY/a+zZQ2selP5Vg/
NWw3A4Q/6l6YJKqrNMt+dUJWuGqJjpRuJOBjxk9bmgOdmmvu6fU6eM3J1GWY40tq
E37A1O+Wbzzib7GOm1c04BxgVWPXJ48ERFVRcu/BZAKWXgLUOU+tOzkfTsci8X95
mnXf7GXw9cK5PWsDtmg7BIuWCQol0tlpVBvtET85fPPGRI/sgRju0x4QsCu+tD11
ZtwPfDuANJqtSfSxCGKbRjiViI0MghRuxu9DB1QnbVdXCWwemTvz9F2acIXDrf2r
AeY7qCIKOiiowlC79E9+P4q56Ds3vCyBuV7LDBhhhRFPf7ylFRxtKj0pYvKR5s0A
7MR0N+aSsMgGiOg9urPzIRMofTUe7EqFAAT3FF1OkaqtLK/ThTlkklF4H9F5AW+b
Zg9iUg1WgPVbpH57mRMv+KDdiJ6H7WQxmvfOg8/WUAvcB1c55GUtgFkomfL8a46U
N1EeWpeQhVDvmYxFyJn1VqzLpFHMeH/YQ3myM2KTOEzk1abbSrUowsZ9kieLgKiK
rTXljrbNAcw4MYp3Wh72XX2PBWG6AyNBnjIAsXG62q6WcZ/e/E0=
=veae
-----END PGP SIGNATURE-----

--eJsYljpsSCzg3rJz--