Date: Wed, 9 Apr 2025 12:16:44 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Hannu Krosing <hannuk@google.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Horribly slow pg_upgrade performance with many Large Objects
Message-ID: <Z_arfJajI7RPt7ZJ@nathan>
References: <Z_VE4Q4A2nNCX3Ny@nathan>
 <4044567.1744128814@sss.pgh.pa.us>
 <CAMT0RQSALxZ2DJbq0b5cy+cvmpVxkawmv7c+qTWYObubZVr+2g@mail.gmail.com>
 <4047312.1744130263@sss.pgh.pa.us>
 <Z_VTucTiS01p-d6z@nathan>
 <4050387.1744132029@sss.pgh.pa.us>
 <CAMT0RQTCxjfK_fU4bBLw0Xv61vUEqP4TfNqYJGRmMqqikPBZ3Q@mail.gmail.com>
 <4054389.1744133818@sss.pgh.pa.us>
 <Z_VfxnhSJIa6VQJt@nathan>
 <4055696.1744134682@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="2Cj/f6XvWUd4DfY2"
Content-Disposition: inline
In-Reply-To: <4055696.1744134682@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/Z_arfJajI7RPt7ZJ%40nathan>
Precedence: bulk


--2Cj/f6XvWUd4DfY2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Apr 08, 2025 at 01:51:22PM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> On Tue, Apr 08, 2025 at 01:36:58PM -0400, Tom Lane wrote:
>>> Hmm ... one annoying thing for this project is that AFAICS pg_upgrade
>>> does *not* preserve database OIDs, which is problematic for using
>>> COPY to load pg_shdepend rows.
> 
>> I think it does; see commit aa01051.
> 
> Ah --- I thought I remembered something having been done about that,
> but I failed to find it because I was looking in pg_upgrade not
> pg_dump.  Too bad aa01051 didn't update the comment at the top of
> pg_upgrade.c.

I'll apply the attached patch to fix the comment shortly.

-- 
nathan

--2Cj/f6XvWUd4DfY2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="v1-0001-Mention-that-we-preserve-database-OIDs-in-pg_upgr.patch"