Date: Fri, 12 Jan 2024 23:13:46 +0530
From: Abhijit Menon-Sen <ams@toroid.org>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: introduce dynamic shared memory registry
Message-ID: <ZaF6UpYImGqVIhVp@toroid.org>
References: <20240102162054.GB955987@nathanxps13>
 <CA+TgmoZRber4XLQC6PaRneh5OECakguePcFD4YUg8qJ+jB+u=g@mail.gmail.com>
 <20240102224907.GA1246933@nathanxps13>
 <CALj2ACWc3Xb6v06T2jkJvEoA9W4aQ+0fY-8w78bY_Dq1ux6GDg@mail.gmail.com>
 <20240106163516.GB2435448@nathanxps13>
 <CALj2ACW4AcGcbwFzFr4RZ62PtcOj=Xg73Xmy_YDQya3g=xVDhQ@mail.gmail.com>
 <20240108171627.GA2611898@nathanxps13>
 <ZZ94oH_5L2rFAywl@paquier.xyz>
 <CALj2ACVaFuUys-Fkq8SQDpTOJnmaqO6C8RshbYtbW-DJD7LbAA@mail.gmail.com>
 <20240112172152.GA3803561@nathanxps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240112172152.GA3803561@nathanxps13>
Archived-At: 
 <https://www.postgresql.org/message-id/ZaF6UpYImGqVIhVp%40toroid.org>
Precedence: bulk

At 2024-01-12 11:21:52 -0600, nathandbossart@gmail.com wrote:
>
> From: Nathan Bossart <nathan@postgresql.org>
> Date: Thu, 11 Jan 2024 21:55:25 -0600
> Subject: [PATCH v6 1/3] reorganize shared memory and lwlocks documentation
> 
> ---
>  doc/src/sgml/xfunc.sgml | 182 +++++++++++++++++++++++++---------------
>  1 file changed, 114 insertions(+), 68 deletions(-)
> 
> diff --git a/doc/src/sgml/xfunc.sgml b/doc/src/sgml/xfunc.sgml
> index 89116ae74c..0ba52b41d4 100644
> --- a/doc/src/sgml/xfunc.sgml
> +++ b/doc/src/sgml/xfunc.sgml
> @@ -3397,90 +3397,136 @@ CREATE FUNCTION make_array(anyelement) RETURNS anyarray
>     </sect2>
>  
> […]
> -     from your <literal>shmem_request_hook</literal>.
> -    </para>
> -    <para>
> -     LWLocks are reserved by calling:
> +      Each backend sould obtain a pointer to the reserved shared memory by

sould → should

> +      Add-ins can reserve LWLocks on server startup.  Like with shared memory,

(Would "As with shared memory" read better? Maybe, but then again maybe
it should be left alone because you also write "Unlike with" elsewhere.)

-- Abhijit