Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 15 Jan 2024 13:11:26 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	Alexander Lakhin <exclusion@gmail.com>,
	"Yu Shi (Fujitsu)" <shiy.fnst@fujitsu.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	Thomas Munro <thomas.munro@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Test slots invalidations in 035_standby_logical_decoding.pl only
 if dead rows are removed
Message-ID: <ZaSwbl4AYcHS-zzP@paquier.xyz>
References: <ZZ7GpII4bAYN+jT5@ip-10-97-1-34.eu-west-3.compute.internal>
 <5d0e5bec-67f9-9164-36cb-c4ff5f95d1ed@gmail.com>
 <ZaACEPtVovKlRVUf@ip-10-97-1-34.eu-west-3.compute.internal>
 <6f85667e-5754-5d35-dbf1-c83fe08c1e48@gmail.com>
 <ZaBlU5FqOeDqyHtJ@paquier.xyz>
 <ZaDnIMTbT+0yR5LZ@ip-10-97-1-34.eu-west-3.compute.internal>
 <cc7925b8-30cc-c76d-b1b6-c9ec6bd36a03@gmail.com>
 <ZaFCoJ1FxBQ9jQkX@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZaSthTtVmvKKuGNb@paquier.xyz>
 <1375923.1705291719@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="bXnikHp6yLVRN+vH"
Content-Disposition: inline
In-Reply-To: <1375923.1705291719@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/ZaSwbl4AYcHS-zzP%40paquier.xyz>
Precedence: bulk


--bXnikHp6yLVRN+vH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 14, 2024 at 11:08:39PM -0500, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> While thinking about that, a second idea came into my mind: a
>> superuser-settable developer GUC to disable such WAL records to be
>> generated within certain areas of the test.  This requires a small
>> implementation, but nothing really huge, while being portable
>> everywhere.  And it is not the first time I've been annoyed with these
>> records when wanting a predictible set of WAL records for some test
>> case.
>=20
> Hmm ... I see what you are after, but to what extent would this mean
> that what we are testing is not our real-world behavior?

Don't think so.  We don't care much about these records when it comes
to checking slot invalidation scenarios with a predictible XID
horizon, AFAIK.
--
Michael

--bXnikHp6yLVRN+vH
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmWksG4ACgkQnvQgOdby
QH0woQ//ZKeuFWu0UAkmWsi60AxfAMocAkPp24KCkmj12Grb/RCfX6T4tZuhw6Hx
923Kg8Y96WYWjPKlexCOST3ceDjXXDmds6H60tQo2OblN7wWgKMmlCunALgIxXGI
n/C6ZfKLUPgFbn2pchmUmMEObWRCprmucQYpkmox6/UeSAZ+r9STriT/AE1xNz9w
6WoJBbHYJXn9cytXDFBVMOrw8julclKxhVWM3aiEKzMPG2kdazTy/p6Y+6usn6eT
Xb/NFL2JSBNqH5qBtbSY1mZjTWblfrGVymwRMEoOU6jxZYQ/SEym3DZ79ZI76CC8
RebEc6l5IcvWWwdHerXMYRSplmgfeHESNuOcrYxgLFXKo4G4qj/uC6hrzK2Re7mj
Z07gTUNxvnljo1xlgu5qsWBm323B4TNqcyZru7z5U62BjMKs6DcNq2U5pKYWceWG
7SH0IC04BXC4H2ucBMOQTkckvvTTGjwZHDu7wOrkeDC2urNQJsVG9KscWtrhABlg
DlfdfbeoSXy/VdZ9WOHXI77b/y4bUtsgta1Oh8tQ46GElEwqomNLAHBaFdyRcKIG
Ks4+z1jxDn1kABuzlxFNex23y0i+RrmfNYRkCbmL7fHwjaPk86Dmcy14IzIk1r49
EMtfPc11VnfzsddjbwMm3+89Dd4a+mHGImPmz3U0PWLT6Mr3L3E=
=D3+s
-----END PGP SIGNATURE-----

--bXnikHp6yLVRN+vH--