public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Jelte Fennema-Nio <[email protected]>
Cc: Aleksander Alekseev <[email protected]>
Cc: Pgsql Hackers <[email protected]>
Cc: FabrÃzio de Royes Mello <[email protected]>
Subject: Re: Add test module for Table Access Method
Date: Tue, 16 Jan 2024 13:58:10 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAGECzQQwNZ2sKh+Qfx1X+=ODEfx+9V0ig6CsmBwOOs2CAy+kmQ@mail.gmail.com>
References: <CAFcNs+pcU2ib=jvjNZNboD+M2tHO+vD77C_YZJ2rsGR0Tp35mg@mail.gmail.com>
<[email protected]>
<CAGECzQR0OExsrx33nBkySPkDShSn-izcz+JhVrqTrJwRfAQm6w@mail.gmail.com>
<CAJ7c6TM3=tnDYAWyyvRB6UdeoafXaPPMq+XpafW+ZBcOnkg1gA@mail.gmail.com>
<CAGECzQQwNZ2sKh+Qfx1X+=ODEfx+9V0ig6CsmBwOOs2CAy+kmQ@mail.gmail.com>
On Mon, Jan 15, 2024 at 03:40:30PM +0100, Jelte Fennema-Nio wrote:
> On Mon, 15 Jan 2024 at 14:26, Aleksander Alekseev
> <[email protected]> wrote:
>> To be fair, Postgres uses TAM internally, so there is at least one
>> complete and up-to-date real-life example.
>
> Sure, but that one is quite hard to follow if you don't already know
> lots of details of the heap storage. At least for me, having a minimal
> example was extremely helpful and it made for a great code skeleton to
> start from.
Hmm. I'd rather have it do something useful in terms of test coverage
rather than being just an empty skull.
How about adding the same kind of coverage as dummy_index_am with a
couple of reloptions then? That can serve as a point of reference
when a table AM needs a few custom options. A second idea would be to
show how to use toast relations when implementing your new AM, where a
toast table could be created even in cases where we did not want one
with heap, when it comes to size limitations with char and/or varchar,
and that makes for a simpler needs_toast_table callback.
--
Michaxel
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add test module for Table Access Method
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox