Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 20 Jan 2024 12:09:18 +0900
From: Michael Paquier <michael@paquier.xyz>
To: vignesh C <vignesh21@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
	Andres Freund <andres@anarazel.de>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	nathandbossart@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: fix stats_fetch_consistency value in postgresql.conf.sample
Message-ID: <Zas5Xv0oiKJcOAaY@paquier.xyz>
References: <20220616132306.GD29853@telsasoft.com>
 <20220617.094358.2201653243066915172.horikyota.ntt@gmail.com>
 <20220622230710.r2m4ex5tlf6mveyh@alap3.anarazel.de>
 <20220630.173801.662386227537019720.horikyota.ntt@gmail.com>
 <20220713173000.GD18011@telsasoft.com>
 <Ys9ZOk49mruHPn4q@paquier.xyz>
 <20220713234900.z4rniuaerkq34s4v@awork3.anarazel.de>
 <ZCUKL22GutwGrrZk@telsasoft.com>
 <ZFrnRwFtwYn2gg8u@telsasoft.com>
 <CALDaNm1C1p6mFXZKGoOYw+cikT+POG7pVdWSjOSFqTydwi_hxg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="yGCL2YBORp+3vRsD"
Content-Disposition: inline
In-Reply-To: 
 <CALDaNm1C1p6mFXZKGoOYw+cikT+POG7pVdWSjOSFqTydwi_hxg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Zas5Xv0oiKJcOAaY%40paquier.xyz>
Precedence: bulk


--yGCL2YBORp+3vRsD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Jan 20, 2024 at 07:59:22AM +0530, vignesh C wrote:
> I'm seeing that there has been no activity in this thread for more
> than 8 months, I'm planning to close this in the current commitfest
> unless someone is planning to take it forward.

Thanks, that seems right to me.

I have been looking again at the patch after seeing your reply (spent
some time looking at it but I could not decide what to do), and I am
not really excited with the amount of new facilities this requires in
the TAP test (especially the list of hardcoded parameters that may
change) and the backend-side changes for the GUC flags as well as the
requirements to make the checks flexible enough to work across initdb
and platform-dependent default values.  In short, I'm happy to let
003_check_guc.pl be what check_guc was able to do (script gone in
cf29a11ef646) for the parameter names.
--
Michael

--yGCL2YBORp+3vRsD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmWrOV4ACgkQnvQgOdby
QH1gLxAAhdiR10PwP6WlsVecqHYxy6OCvRgNjbQRlZtCb5iu64kKmUx65rOI2vEY
PiWpWhH9pkfWCM6ur6dtIP4UBlwL0VMhq4GxDW4c70WhLeVT7/jJ0QDuNJEwo9mK
I2oNNx3U1PiCo76Tfi01SdYRuSgy8WncK+Gb40kiE9XjNGuz6Z3INR3Ia6V7Y7YB
70w9pu8yP3NV7rytMMgQ/RBY6A0CmIoKXVqlQivqkC7VNOlhzmk9xpr1Vk+b0GbX
zNlz+xXsUR6XU1ss0TVNyWdEKK+KMqjGfjdZho2bna5K7isl4MtzIk56T6XHqT+w
ZEO/5N4Jbr1HKglCK4gpeg0rAjz+ttioi8Z7ydvDeHPrZA7CqZ9+cXb99g/kzVsH
tWMqNR7+FVn/yy1eSFnDhQ3akqmqbTk/ismmdoD+Iuowz98RRxfNGTanlNnoaGLJ
zT1W5JV5iMEBsRlkq5WWcIBarwfXyPyj1Dz6p8lQsJRLMX3tlZpsTto8Pnsu7m6m
ijcWFkox1Vdj25RIskuuE6/LjFKmlOtjhGuSocNRbbHAu6bl5WHz+qrWbuyQjLU1
BtrlONLCXJ3Kr7ae8I/dyzM+atKULQ2nsllCrBnHrUAy1D7vn/9LTXuAMmLV3R0Z
IQyfkpf67qFRhVlBbcGmU6BMshaAhpeq2e/Ojm/XO8YlQJHX73Q=
=Tr6M
-----END PGP SIGNATURE-----

--yGCL2YBORp+3vRsD--