public inbox for [email protected]
help / color / mirror / Atom feedFrom: Bertrand Drouvot <[email protected]>
To: Amit Kapila <[email protected]>
Cc: shveta malik <[email protected]>
Cc: Zhijie Hou (Fujitsu) <[email protected]>
Cc: Ajin Cherian <[email protected]>
Cc: Masahiko Sawada <[email protected]>
Cc: Dilip Kumar <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: Nisha Moond <[email protected]>
Cc: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: Bharath Rupireddy <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Ashutosh Sharma <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Subject: Re: Synchronizing slots from primary to standby
Date: Mon, 29 Jan 2024 09:15:57 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAA4eK1LumO2+A7RLkEW2ViA_KkgYpDgv9BbqSNGu0w3osanH4g@mail.gmail.com>
References: <CAA4eK1Lxvfq9RwOEsguiMCrKPUc1He9UGz1_wi0N0cJaXFa4Eg@mail.gmail.com>
<OS0PR01MB5716E304C26E6ACE0BE84925947A2@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<[email protected]>
<CAA4eK1K0jRXa2AhKXRVDY+Y42MG4RTbfAEcTBEGN2ov=Yjco+A@mail.gmail.com>
<OS0PR01MB571623B1D01003F99A7BB983947A2@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<CAA4eK1+3jV839U3+DGgHrgrhtDguaVwAyb0Hucz9UbpjjVL=Sg@mail.gmail.com>
<OS0PR01MB5716DE2A364CB23F9144AED194782@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<CAJpy0uBX2tyF4bQn-rd8zqoVLr+j53uWp+fh3qbLfXwCnKed4A@mail.gmail.com>
<[email protected]>
<CAA4eK1LumO2+A7RLkEW2ViA_KkgYpDgv9BbqSNGu0w3osanH4g@mail.gmail.com>
Hi,
On Mon, Jan 29, 2024 at 02:35:52PM +0530, Amit Kapila wrote:
> On Mon, Jan 29, 2024 at 2:22 PM Bertrand Drouvot
> <[email protected]> wrote:
> > Looking at 0001:
> >
> > + When altering the
> > + <link linkend="sql-createsubscription-params-with-slot-name"><literal>slot_name</literal></link>,
> > + the <literal>failover</literal> property value of the named slot may differ from the
> > + <link linkend="sql-createsubscription-params-with-failover"><literal>failover</literal></link>
> > + parameter specified in the subscription. When creating the slot,
> > + ensure the slot <literal>failover</literal> property matches the
> > + <link linkend="sql-createsubscription-params-with-failover"><literal>failover</literal></link>
> > + parameter value of the subscription. Otherwise, the slot on the publisher may
> > + not be enabled to be synced to standbys.
> >
> > Not related to this patch series but while at it shouldn't we also add a few
> > words about two_phase too? (I mean ensure the slot property matchs the
> > subscription one).
> >
> > Or would it be better to create a dedicated patch (outside of this thread) for
> > the "two_phase" remark? (If so I can take care of it).
> >
>
> I think it is better to create a separate patch for two_phase after
> this patch gets committed.
Yeah, makes sense, will do, thanks!
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
view thread (119+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Synchronizing slots from primary to standby
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox