Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 31 Jan 2024 14:39:54 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sutou Kouhei <kou@clear-code.com>
Cc: sawada.mshk@gmail.com, zhjwpku@gmail.com, andrew@dunslane.net,
	nathandbossart@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: Make COPY format extendable: Extract COPY TO format
 implementations
Message-ID: <ZbndKiFBfPErY282@paquier.xyz>
References: <ZbijVn9_51mljMAG@paquier.xyz>
 <20240130.171511.2014195814665030502.kou@clear-code.com>
 <Zbi1TwPfAvUpKqTd@paquier.xyz>
 <20240131.141122.279551156957581322.kou@clear-code.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="cJg5hbLOUpdhvoB2"
Content-Disposition: inline
In-Reply-To: <20240131.141122.279551156957581322.kou@clear-code.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZbndKiFBfPErY282%40paquier.xyz>
Precedence: bulk


--cJg5hbLOUpdhvoB2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jan 31, 2024 at 02:11:22PM +0900, Sutou Kouhei wrote:
> Ah, yes. defel->location is used in later patches. For
> example, it's used when a COPY handler for the specified
> FORMAT isn't found.

I see.

> I've prepared the v10 patch set. Could you try this?

Thanks, I'm looking into that now.

> FYI: Here are Copy{From,To}Routine in the v10 patch set. I
> think that only Copy{From,To}OneRow are minimal callbacks
> for the performance gain. But can we keep Copy{From,To}Start
> and Copy{From,To}End for consistency? We can remove a few
> {csv_mode,binary} conditions by Copy{From,To}{Start,End}. It
> doesn't depend on the number of COPY target tuples. So they
> will not affect performance.

I think I'm OK to keep the start/end callbacks.  This makes the code
more consistent as a whole, as well.
--
Michael

--cJg5hbLOUpdhvoB2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmW53SoACgkQnvQgOdby
QH1MYBAAiPBM+YHEdGDezCbjxs1pUV7Yh1n/GpiaKzfb+Fzi0VLKHF9HJjhArdn2
ZXivX0Kw/1iLXbP4n/xISBnNU6Y9fMS3RbWQOcF2a77tTIK0vZqJb8un19o+NKdX
WtoqXhTxJfCvhRHsOM8hM679tDfO2cTI1YoSFAKTkvE+U0pQGo9zUGsI7vcvPE77
DggY9I80pAgykl7wnKzmbq6w/dClGIwnW/Z21RddDVQXTPImZAKtYUQGXlMoDJNo
+OcZ1NjYvPz4wZ28LRP70gnGJ4qd8Zzogmx5pswmhSMqsu0p/ZDgg+iQ4DW1AhYX
MmYtExLteTMlaGlgf6m/b9Ius5CWe4NoY5zqOnI81TA0/58gKiu8hmKdKxErwlgJ
oD+GlEGS398PLeALWEwXfrzHu2pmhOz1ANR15Xlgo9aRKQYkvm2Ngw1OzTGNCVuR
/PA2+3Rq1ZP/x7whsJphE0AFaFdCQCizh4LBwp9LsC8Q7IP8z6HSavZoSFZVgB+y
otVNBOliyVeXhYLTvwXGiRKy37s6tv1rF8IKv0eP3UI7yYe+XcSV5HBWLuhs0iui
owLHgQXUeX3P1VUYa6MEVLRCpp5PA/Y3grwbO7eTGz636W4zZ0CxWh7j3NabOCT+
+cePsb2WhrrhWC63ALXgOWYiicFsGbJYIaMXIM8c00ndZWq6SJg=
=q2If
-----END PGP SIGNATURE-----

--cJg5hbLOUpdhvoB2--