Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 1 Feb 2024 12:49:59 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sutou Kouhei <kou@clear-code.com>
Cc: sawada.mshk@gmail.com, zhjwpku@gmail.com, andrew@dunslane.net,
	nathandbossart@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: Make COPY format extendable: Extract COPY TO format
 implementations
Message-ID: <ZbsU53b3eEV-mMT3@paquier.xyz>
References: <ZbijVn9_51mljMAG@paquier.xyz>
 <20240130.171511.2014195814665030502.kou@clear-code.com>
 <Zbi1TwPfAvUpKqTd@paquier.xyz>
 <20240131.141122.279551156957581322.kou@clear-code.com>
 <ZbndKiFBfPErY282@paquier.xyz>
 <Zbr6piWuVHDtFFOl@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="DdknzyKB5K/ZWqv8"
Content-Disposition: inline
In-Reply-To: <Zbr6piWuVHDtFFOl@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/ZbsU53b3eEV-mMT3%40paquier.xyz>
Precedence: bulk


--DdknzyKB5K/ZWqv8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 01, 2024 at 10:57:58AM +0900, Michael Paquier wrote:
> And here are the results I get for text and binary (ms, average of 15
> queries after discarding the three highest and three lowest values):
>       test       | master |  v7  | v10 =20
> -----------------+--------+------+------
>  from_bin_1col   | 1575   | 1546 | 1575
>  from_bin_10col  | 5364   | 5208 | 5230
>  from_text_1col  | 1690   | 1715 | 1684
>  from_text_10col | 4875   | 4793 | 4757
>  to_bin_1col     | 1717   | 1730 | 1731
>  to_bin_10col    | 7728   | 7707 | 7513
>  to_text_1col    | 1710   | 1730 | 1698
>  to_text_10col   | 5998   | 5960 | 5987

Here are some numbers from a second local machine:
      test       | master |  v7  | v10 =20
-----------------+--------+------+------
 from_bin_1col   | 508    | 467  | 461
 from_bin_10col  | 2192   | 2083 | 2098
 from_text_1col  | 510    | 499  | 517
 from_text_10col | 1970   | 1678 | 1654
 to_bin_1col     | 575    | 577  | 573
 to_bin_10col    | 2680   | 2678 | 2722
 to_text_1col    | 516    | 506  | 527
 to_text_10col   | 2250   | 2245 | 2235

This is confirming a speedup with COPY FROM for both text and binary,
with more impact with a larger number of attributes.  That's harder to
conclude about COPY TO in both cases, but at least I'm not seeing any
regression even with some variance caused by what looks like noise.
We need more numbers from more people.  Sutou-san or Sawada-san, or
any volunteers?
--
Michael

--DdknzyKB5K/ZWqv8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmW7FOcACgkQnvQgOdby
QH0e1g//YUgZpoLeI0miAnoL+K+XoHLwEvC2t9hbu9IeFyh2VBVu739m6/FKMsy8
wlGnBtGM9a36soAqKyMUgg+4DWRIwFQ+HrTCVr4SgjX/uTl7ydymMsbH+wpYUoE9
unonLn8AkZHdbWjD8GgaE1sRFOKoUGbqxs+h3xJoZ4jOi/VLyizxnAiLPWvhobfA
sXb0djYp4AHnR6oLLp+6AjadugdDDBhQrhQf4RgkXuhxR2mswVQ/4uE32yJIWk6K
Q98OKej9+VeOlxLXyYvCje/B+HvK7C8E2X0kV/4M60SfW2Q+t9sPPddEXfQKGNCK
sjxT+FnBeHrIp+mV5ExL9tXoWrGYfbvkAeK/Lzf9tERwiXGzt/qVRJq91BUX9vve
ytx6wjpZpJsrLWoinqxCKIJIiAjyCLeeMTN22exwkGaEtibwppBBUMbd5BWmc9zM
8CKecU09lx5YHTJlT0J0mcHOsfxr3iyzSsjJ4F2XBNc4wfHfPtwJAnWmJ2Kcjo/B
LTuTU+Aclfwz3cXIY++DVtnElHacXMJxeoXBfsPa3Yubfo97Q6yqIEGRe2UC3K9S
sZGUY9z0I4GNx/ybcA7xa/4NVTFg8t2KUPjGSu9rnsQqmm7AXpGZJ1LUJd/KE1u8
yy0ep+k3jmoojpF1KccY/Jwa+Y4Hu7jc9Ad8D7utwsycJn5hKWE=
=Ht5z
-----END PGP SIGNATURE-----

--DdknzyKB5K/ZWqv8--