Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 2 Feb 2024 06:46:13 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
	Soumyadeep Chakraborty <soumyadeep2007@gmail.com>,
	Zhihong Yu <zyu@yugabyte.com>, pgsql-hackers@postgresql.org,
	Ashwin Agrawal <ashwinstar@gmail.com>, vanjared@vmware.com
Subject: Re: ALTER TABLE SET ACCESS METHOD on partitioned tables
Message-ID: <ZbwRJd6x5fb6ppk2@paquier.xyz>
References: <ZLgn3Ou4YpgP8Z8l@telsasoft.com>
 <202402011550.sfszd46247zi@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="BbDxQ4fshriDFvh0"
Content-Disposition: inline
In-Reply-To: <202402011550.sfszd46247zi@alvherre.pgsql>
Archived-At: <https://www.postgresql.org/message-id/ZbwRJd6x5fb6ppk2%40paquier.xyz>
Precedence: bulk


--BbDxQ4fshriDFvh0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Feb 01, 2024 at 04:50:49PM +0100, Alvaro Herrera wrote:
> I think this works similarly but not identically to tablespace defaults,
> and the difference could be confusing.  You seem to have made it so that
> the partitioned table _always_ have a table AM, so the partitions can
> always inherit from it.  I think it would be more sensible to _allow_
> partitioned tables to have one, but not mandatory; if they don't have
> it, then a partition created from it would use default_table_access_method.

You mean to allow a value of 0 in pg_class.relam on a partitioned
table to allow any partitions created on it to use the default AM in
the GUC when the partition is created?  Yes, this inconsistency was
bothering me as well in the patch.
--
Michael

--BbDxQ4fshriDFvh0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmW8ESUACgkQnvQgOdby
QH0pSQ//dsczNO/LQ3Z2D+CFo1gThAe75HdN4O5BVKg+ztmsHvQ5P5f/Ldx8Y7Fp
YDgKSNvCwKV6lvbeWjMtDO33oDBWiu9W8980iFucATwo8hhT5gFVMJCns7dFboDr
/AbSTv08bx6a/31XfbMOvWDocx2uB2ddZo7CaX+ASnIBw/7bxjrIG5ZkRVDWKpoS
auZ6CaxNYBTpBxqm+GmAQbZyqSnSMv7niQ0Ks1cvnrlSZ3wWWj/6T1M+eTQavxzq
prQf85U+tmacIxc3rX+SyBWcCdXeR59EoPwTGBBBqbcI4cRjMi2QvOSAnkOJUA19
49T9xtxMY4wNFNa7xLDjTKse2qS+oFcTTG5wmzOO3D/C2Kdyfuk5renGCkaPRtNQ
FRNWyaDjU9DLVhGM2+Gr9SlcgyN2tneXZ2BM06X61gzEzGZls8GaXtJxmc1uT5Ii
ADVRXA6XGxfG20PsAN5vevyqfZ3pVVRkbeuslB6c9evSl6FIOxTGPhyPnTd6moKF
nMuMNQotFaK7f1Gh7hTpSHTd7SJfu0tJrHGS+Ht5reZlrNTMv6UUit2WUWkyhH4c
POk4wy0N0athrXsj75IxHq9PGWieKfS6axHTCfRm33tSEcAjn1Ze6evHmOL9nsg+
Ktv2Q8ugugArj5g4Lzq3pBpHGMblpSPk68bEDRipAu4197Xj5k8=
=RGUt
-----END PGP SIGNATURE-----

--BbDxQ4fshriDFvh0--