Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 15 Feb 2024 13:28:56 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Anton Voloshin <a.voloshin@postgrespro.ru>,
	Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: 039_end_of_wal: error in "xl_tot_len zero" test
Message-ID: <Zc2TCE7wiSVq6qTC@paquier.xyz>
References: <b26aeac2-cb6d-4633-a7ea-945baae83dcf@postgrespro.ru>
 <CA+hUKGL47fv64v6kXyz5t69yQdhp2KKFe4eR63Sk7Aitzxv=_A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="uH+FwzKSGp5+u52u"
Content-Disposition: inline
In-Reply-To: <CA+hUKGL47fv64v6kXyz5t69yQdhp2KKFe4eR63Sk7Aitzxv=_A@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Zc2TCE7wiSVq6qTC%40paquier.xyz>
Precedence: bulk


--uH+FwzKSGp5+u52u
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 19, 2024 at 11:35:30AM +1300, Thomas Munro wrote:
> On Fri, Jan 19, 2024 at 1:47=E2=80=AFAM Anton Voloshin
> <a.voloshin@postgrespro.ru> wrote:
>> I believe there is a small problem in the 039_end_of_wal.pl's
>> "xl_tot_len zero" test. It supposes that after immediate shutdown the
>> server, upon startup recovery, should always produce a message matching
>> "invalid record length at .*: wanted 24, got 0". However, if the
>> circumstances are just right and we happened to hit exactly on the edge
>> of WAL page, then the message on startup recovery would be "invalid
>> magic number 0000 in log segment .*, offset .*". The test does not take
>> that into account.
>=20
> Thanks for figuring this out!  Right, I see.  I will look more closely
> when I'm back from summer vacation in a few days, but first reaction:

Thomas, are you planning to look at that?
--
Michael

--uH+FwzKSGp5+u52u
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmXNkwgACgkQnvQgOdby
QH2IRw/9HZrLtkr8NnegQQ5IqF+VWIqsYgI5L06TnOYstQYJf0/H+yKjiEf+X/ps
Ps5hxw3o8CddoBqo85BZ45n0UF8NmNdwNvrEtHJR7fvk/sKZo50zdd1Z7/PYtrOp
md4CFV1MfFG0GjdMduYOFLoL3mGjWjGiExGyhYlpdbYdLLNQbG469jYG+pBMr7ab
YvmUKPqojpX7kpPJ/uCL60FWVGcGcEQTzbWpkgvkNtHc1qVn1ulBA4cLI+TFn+rO
3Rk6ZYqunVH1buWdsyymsTpC1HviRUYthZNPaVGWtvkInDjYosZ6Tc8hhW10eZZK
ZxI12yYYRnc2jrLZlQAeW9PLty3hFtvQcJMrUIUvWdf/a96IsLe6/bilT3B9/JZk
ZgpmqmQSIihagKAUpJRw0gJ488g8PR2JtgWgk/nCA4g4EsUI13TkbBXdQ27VAVxS
fCqyGmjY4O/rR2QjYdL4168QOu1Hn5D69umZCRV2XJAFORtIfMJc0t35BQIU/OnN
S6PtSNWL8ZW/25s8Lz54M04QZaw9IDcd5PbQsNIe21bvxt5xtasu/dl9i3s//2D9
B99Oyk9F5RKX0L63QNJNGKMDQfag0Kthr3+8fbUMlZ6RxvYJu2gYcw532rp81/7o
Lw4mqIDNDjfb0hARqX4RUkCnQ43uY8GHgE6mQN/T5Fwd2hcX/aA=
=PX8/
-----END PGP SIGNATURE-----

--uH+FwzKSGp5+u52u--