Date: Thu, 15 Feb 2024 03:46:57 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, vignesh C <vignesh21@gmail.com>,
	Masahiko Sawada <sawada.mshk@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	Peter Smith <smithpb2250@gmail.com>,
	Julien Rouhaud <rjuju123@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade and logical replication
Message-ID: <Zc3dkaa5q-PDrNJQ@pryzbyj2023>
References: 
 <CAA4eK1K-YGFOmS=Gi-GST0A5Xx4zBsoXn0TebDtZFNKUmjDPww@mail.gmail.com>
 <ZW60c-tpTNB5noL8@paquier.xyz>
 <CALDaNm27+B6hiCS3g3nUDpfwmTaj6YopSY5ovo2=__iOSpkPbA@mail.gmail.com>
 <CAD21AoBN6T+vPQuf_y9vrUX7dhOfmkVjqc4vQwdDozTH_xZa4g@mail.gmail.com>
 <CALDaNm3p16KYd70QKV9qYHqWqQV1G4i2ugaifst9Viwfp_XkpA@mail.gmail.com>
 <CAA4eK1+TqV7Gcsu=Ai2iSy6fH-gi6MKocX+L52_g567b1O5gig@mail.gmail.com>
 <CALDaNm20wZwWcjF+OmwEAa7ugREPKyY0L29ngkug33DhNWz_hA@mail.gmail.com>
 <CAA4eK1+dM0DcFRgaLp3syN0FMM2DAkp8PmtTUdgymx5D0d4y_w@mail.gmail.com>
 <ZcvZipRoi_kopIpb@pryzbyj2023>
 <TYCPR01MB120773E8D02D58F50B24DA6ADF54E2@TYCPR01MB12077.jpnprd01.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <TYCPR01MB120773E8D02D58F50B24DA6ADF54E2@TYCPR01MB12077.jpnprd01.prod.outlook.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Zc3dkaa5q-PDrNJQ%40pryzbyj2023>
Precedence: bulk

On Wed, Feb 14, 2024 at 03:37:03AM +0000, Hayato Kuroda (Fujitsu) wrote:
> Attached patch modified the test accordingly. Also, it contains some optimizations.
> This can pass the test on my env:

What optimizations?  I can't see them, and since the patch is described
as rearranging test cases (and therefore already difficult to read), I
guess they should be a separate patch, or the optimizations described.

-- 
Justin