Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 6 Feb 2024 15:11:05 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Sutou Kouhei <kou@clear-code.com>, sawada.mshk@gmail.com,
	zhjwpku@gmail.com, andrew@dunslane.net, nathandbossart@gmail.com,
	pgsql-hackers@postgresql.org
Subject: Re: Make COPY format extendable: Extract COPY TO format
 implementations
Message-ID: <ZcHNeaMxzRCRH7lL@paquier.xyz>
References: <ZbyJ60Fd7CHt4m0i@paquier.xyz>
 <20240202.163319.975394400703526633.kou@clear-code.com>
 <ZbyiDHIrxRgzYT99@paquier.xyz>
 <20240202.174618.349091157390883477.kou@clear-code.com>
 <ZcCKwAeFrlOqPBuN@paquier.xyz>
 <20240205182118.h5rkbnjgujwzuxip@awork3.anarazel.de>
 <ZcGE8LrjGW8pmtOf@paquier.xyz>
 <20240206014125.qofww7ew3dx3v3uk@awork3.anarazel.de>
 <ZcGcQq3Y6FeX1z4e@paquier.xyz>
 <20240206054642.qikm7s7jzy4bmdzn@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ZboHWEV4jPMDjkgG"
Content-Disposition: inline
In-Reply-To: <20240206054642.qikm7s7jzy4bmdzn@awork3.anarazel.de>
Archived-At: <https://www.postgresql.org/message-id/ZcHNeaMxzRCRH7lL%40paquier.xyz>
Precedence: bulk


--ZboHWEV4jPMDjkgG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 05, 2024 at 09:46:42PM -0800, Andres Freund wrote:
> No - what I mean is that it doesn't make sense to have copy_attribute_out(),
> as e.g. CopyToTextOneRow() already knows that it's dealing with text, so it
> can directly call the right function. That does require splitting a bit more
> between csv and text output, but I think that can be done without much
> duplication.

I am not sure to understand here.  In what is that different from
reverting 2889fd23be56 then mark CopyAttributeOutCSV and
CopyAttributeOutText as static inline?  Or you mean to merge
CopyAttributeOutText and CopyAttributeOutCSV together into a single
inlined function, reducing a bit code readability?  Both routines have
their own roadmap for encoding_embeds_ascii with quoting and escaping,
so keeping them separated looks kinda cleaner here.
--
Michael

--ZboHWEV4jPMDjkgG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmXBzXkACgkQnvQgOdby
QH3dMw/8DO6MaiG5xl9nQydlUqX6ZCqEMeafhS8Vh7nHwDkzl1zyXJp7z3wmRP5t
43c57VrPCFdFlzl5iB4AnTl1s2M79dM60huT1f5NoCIYSc395VqNBCUOVtJmMqax
5ez7E5qbJYQhQxxsoZr0K4uLikD3RmDBJu58LhD1jVbgh39RmeWQaIjJ4LCUE/f/
dvVXMCXF9jsnIGh+VaqGoNrmb76IlF/d0tGMXfS1pMbuKqeMHCl7DTVHY/Qd+fxI
4N+1OwSuEzNNNpiMRn2TJJTr5tNDH2r533sY+/QqfCZytnwRmRbOAi4DfRuK2rh9
9gQvfeGvv8FwEMm5MNW2WYPcKJtGrseQ3ViAKdTNGbtfn9eO1BJjtP9HdVZce3IB
iYf0PI7kfDEYFUXQ8Nh2COi1NXPep8ruWvCqZenCCJS4k/fuuhcPQPaMMpnVFXd5
scTCy+UVXRSoD0cPYeawyprcGUNxhD4SXn2YlQuke3z2VmqRGm71nlIIlW8dLLZT
c/yYkmHZqLfgrpjzrEdqFmSsuoRbfCWBa+3lQoj5BFs4pbNdLTFyW+ac4qdiBDhG
EmgIHPK+TStUGGK5MmUNdGEyBYe5qXch7sXJUvlc6iekm/jqXO12JpEoRfAHXV0D
PmVvtissbnuGkDHK3uNQAtNYJ6rKoenRHH28fuz1cfdXOaV0GnM=
=S2MW
-----END PGP SIGNATURE-----

--ZboHWEV4jPMDjkgG--