Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rZoHe-006VPN-VS for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Feb 2024 08:36:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rZoHe-00GKjC-1T for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Feb 2024 08:36:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rZoHd-00GKj4-Ok for pgsql-hackers@lists.postgresql.org; Tue, 13 Feb 2024 08:36:53 +0000 Received: from wfout5-smtp.messagingengine.com ([64.147.123.148]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rZoHb-006x7V-WA for pgsql-hackers@postgresql.org; Tue, 13 Feb 2024 08:36:53 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.west.internal (Postfix) with ESMTP id A339C1C00096; Tue, 13 Feb 2024 03:36:48 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 13 Feb 2024 03:36:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1707813408; x=1707899808; bh=UagIr0aKYu cV8DFgRqWVoaQgX50tkUUzxQIFGvSsMKE=; b=YuscYkezFgmHLslK4mq0lsFhV0 NnGKoss/IsnBNoUN21HPXe4fdkfkfTN5TaXzzUZIN1gnHjPhJ9LJymEK1k1Dd2FS o3zsMePCMzuscZjI9dT+VwbIZ5f8kzmt/lM8uei4tnI1Tm7BhqY9j+qmXXAnkrOs JlEk/WJYNBIjiuzf39et5tyo4U8gqM/s8usXATXZfgkey9UXvoLFhRYpuWnbW1v1 MWYQn7wZ2TiRcv2wlGXXaw8ane10Fo88YbMNjxivaClk/JoFvz2Vqf7RcgZRIjtE 08axg+1paKfvOTbJPhe2wfXfYPpEfvMNciZCBd5DA92JnVxas7G6ofTgW2zg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1707813408; x=1707899808; bh=UagIr0aKYucV8DFgRqWVoaQgX50t kUUzxQIFGvSsMKE=; b=ngTP6U7hTCGK1jVn9i9o6VIe19ayjjZ+zLl+/0ZQMwBi R1ccyiLD84Ax/dxi2/uVnqZ4p4UuO/mQeubXfI8vWNajVZKu7gaHafsS9d2Bgzk9 6qnqXsO5MSNkgdlUwTEcmCVgX0VBnS5d0AaYrATK1GJvLoX5XDHKoXCliKmaygSB V80i0Nn2qhUPkaJzY07SSJFJlnph0ew+Q7OoMl4wBIMRCNKbb3xIPTXDm2KUsaOU oVAKcPQBwFj/DzcjHqlwCrkUznxbkpzIEtwS+3AhPCvCp0b4EPqsvEp4yZZWI9Rb mlqZ3D++0iJ5LWfNtu494kx1fRNGuH6M72rEtZx7JQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudeggdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Feb 2024 03:36:46 -0500 (EST) Date: Tue, 13 Feb 2024 17:36:36 +0900 From: Michael Paquier To: shihao zhong Cc: PostgreSQL-development Subject: Re: Fix incorrect PG_GETARG in pgcrypto Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LH4cb6iKt6xNBXvr" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --LH4cb6iKt6xNBXvr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 12, 2024 at 11:30:40PM -0500, shihao zhong wrote: > I'd like to bring to your attention that I recently identified some > functions in pgcrypto that are using PG_GETARG functions in a way that > doesn't match the expected function signature of the stored > procedures. This patch proposes a solution to address these > inconsistencies and ensure proper alignment. You've indeed grabbed some historical inconsistencies here. Please note that your patch has reversed diffs (for example, the SQL definition of pgp_sym_encrypt_bytea uses bytea,text,text as arguments and your resulting patch shows how HEAD does the job with bytea,bytea,bytea), but perhaps you have generated it with a command like `git diff -R`?=20 -- Michael --LH4cb6iKt6xNBXvr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmXLKhQACgkQnvQgOdby QH2HdQ//T+JOa4Uhbv1zgfa7r/cowCx5FTT4oqu1Mx73fjZeWBEMuJdBRT5E+DHz 2QSr0WfG0tP1bSvT92IQQshUZdzGLdHPmbjwOmluzCJAtSLDp1G+Z1iT2rb4FrTH Qz/VCssJ+9nu1A4q3yMIA9FFl6RFc3yx/WMM3J5ob6UZlP+vThVaDqgCA7yjiVwJ MKoqZe61avpY7Hy+sONWa+YEp2K3UlGgRuxNpugT7cus7fYRGePce+2eQjXGH/KS DJVMczEvMsTAd4tKJLuPxCicNqZhxC2Dc+8PbwwcOTBcalked3RhiElH97CA9Ke/ SWHOYjI2cxfS7YYAVzQUa68zdfJGCqepvXfGqt2lBG9M08isBaoF2lUefiJ9PBfp GSuoQ3Sjdb7t9FRF8qcuuGfMcoPo1qVVhD7irkqMIT029n/LvEq1MK5yf8dcIgz5 Ss8kLULbfR+SDUfzhtX5VkyW6xEhSVFw7J/Rv+WJn5OZhxkOcpZXby10Luq88pd2 Er4lN3YsJpl+a2SW8HQnh/BQgdpucm3tPfr8sFdBkkaQq9RjKfvKB24C6/3jN8H1 oSSEcrwH+wQCXx+swjOz3HelIRyMRVdvWDHT8/c7MDRq0fv49YZKVmyJ9a8LLYXz xG94LajI6nMseYthWLvy+zHmc8OXo82S5g9xRg/APTsDeslnqYs= =LwzX -----END PGP SIGNATURE----- --LH4cb6iKt6xNBXvr--