public inbox for [email protected]help / color / mirror / Atom feed
[PATCH 06/10] Default to LZ4.. 5+ messages / 3 participants [nested] [flat]
* [PATCH 06/10] Default to LZ4.. @ 2021-03-12 21:35 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Justin Pryzby @ 2021-03-12 21:35 UTC (permalink / raw) this is meant to exercise in the CIs, and not meant to be merged --- configure | 6 ++++-- configure.ac | 4 ++-- src/backend/access/transam/xlog.c | 2 +- src/backend/utils/misc/guc.c | 2 +- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/configure b/configure index fed440adcf..8d76be00c1 100755 --- a/configure +++ b/configure @@ -1575,7 +1575,7 @@ Optional Packages: --with-system-tzdata=DIR use system time zone data in DIR --without-zlib do not use Zlib - --with-lz4 build with LZ4 support + --without-lz4 build without LZ4 support --with-gnu-ld assume the C compiler uses GNU ld [default=no] --with-ssl=LIB use LIB for SSL/TLS support (openssl) --with-openssl obsolete spelling of --with-ssl=openssl @@ -8598,7 +8598,9 @@ $as_echo "#define USE_LZ4 1" >>confdefs.h esac else - with_lz4=no + with_lz4=yes + +$as_echo "#define USE_LZ4 1" >>confdefs.h fi diff --git a/configure.ac b/configure.ac index 8c454128bb..bfcdc88be0 100644 --- a/configure.ac +++ b/configure.ac @@ -990,8 +990,8 @@ AC_SUBST(with_zlib) # LZ4 # AC_MSG_CHECKING([whether to build with LZ4 support]) -PGAC_ARG_BOOL(with, lz4, no, [build with LZ4 support], - [AC_DEFINE([USE_LZ4], 1, [Define to 1 to build with LZ4 support. (--with-lz4)])]) +PGAC_ARG_BOOL(with, lz4, yes, [build without LZ4 support], + [AC_DEFINE([USE_LZ4], 1, [Define to 1 to build without LZ4 support. (--without-lz4)])]) AC_MSG_RESULT([$with_lz4]) AC_SUBST(with_lz4) diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 984ce39cc7..3657f74de9 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -99,7 +99,7 @@ bool EnableHotStandby = false; bool fullPageWrites = true; bool wal_log_hints = false; bool wal_compression = false; -int wal_compression_method = WAL_COMPRESSION_ZLIB; +int wal_compression_method = WAL_COMPRESSION_LZ4; char *wal_consistency_checking_string = NULL; bool *wal_consistency_checking = NULL; bool wal_init_zero = true; diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index c37a8313d3..52f9cd0242 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -4728,7 +4728,7 @@ static struct config_enum ConfigureNamesEnum[] = NULL }, &wal_compression_method, - WAL_COMPRESSION_ZLIB, wal_compression_options, + WAL_COMPRESSION_LZ4, wal_compression_options, NULL, NULL, NULL }, -- 2.17.0 --XsQoSWH+UP9D9v3l Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0007-add-wal_compression_method-zstd.patch" ^ permalink raw reply [nested|flat] 5+ messages in thread
* [PATCH] updates to docs about HOT updates for BRIN @ 2024-02-26 20:29 Elizabeth Christensen <[email protected]> 0 siblings, 1 reply; 5+ messages in thread From: Elizabeth Christensen @ 2024-02-26 20:29 UTC (permalink / raw) To: [email protected] Hello, I have a small documentation patch to the HOT updates page <https://www.postgresql.org/docs/current/storage-hot.html>to add references to summary (BRIN) indexes not blocking HOT updates <https://www.postgresql.org/message-id/[email protected]...;, committed 19d8e2308b. Thanks, Elizabeth Christensen Attachments: [application/octet-stream] 0001-Adding-Summary-Index-Info-to-HOT-Update-Documentatio.patch (2.5K, ../../CABoUFXRjisr58Ct_3VsFEdQx+fJeQTWTdJnM7XAp=8MUbtoa9A@mail.gmail.com/3-0001-Adding-Summary-Index-Info-to-HOT-Update-Documentatio.patch) download | inline diff: From: elizabeth-christensen <[email protected]> Date: Mon, 26 Feb 2024 12:09:22 -0600 Subject: [PATCH] Adding Summary Index Info to HOT Update Documentation page Commit 19d8e2308b changed when the HOT update optimization is possible but neglected to update the Heap-Only Tuples (HOT) documentation. This patch updates that documentation accordingly. Author: Elizabeth Christensen Backpatch-through: 16 Discussion: --- doc/src/sgml/storage.sgml | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/doc/src/sgml/storage.sgml b/doc/src/sgml/storage.sgml index 3ea4e5526d..f12ed31483 100644 --- a/doc/src/sgml/storage.sgml +++ b/doc/src/sgml/storage.sgml @@ -1097,8 +1097,7 @@ data. Empty in ordinary tables.</entry> <itemizedlist> <listitem> <para> - The update does not modify any columns referenced by the table's - indexes, including expression and partial indexes. + The update only modifies columns which are un-indexed or are only + indexed with summarizing indexes (such as <acronym>BRIN</acronym>) + and does not update any columns referenced by the table's non-summary + indexes, including expression and partial non-summary indexes. </para> </listitem> <listitem> @@ -1114,7 +1113,7 @@ data. Empty in ordinary tables.</entry> <itemizedlist> <listitem> <para> - New index entries are not needed to represent updated rows. + New index entries are not needed to represent updated rows, + however, summary indexes may still need to be updated. </para> </listitem> <listitem> @@ -1130,11 +1129,10 @@ data. Empty in ordinary tables.</entry> </para> <para> - In summary, heap-only tuple updates can only be created - if columns used by indexes are not updated. You can - increase the likelihood of sufficient page space for - <acronym>HOT</acronym> updates by decreasing a table's <link - linkend="reloption-fillfactor"><literal>fillfactor</literal></link>. + In summary, heap-only tuple updates can only be created if columns used by + non-summary indexes are not updated. You can increase the likelihood of + sufficient page space for <acronym>HOT</acronym> updates by decreasing + a table's <link linkend="reloption-fillfactor"><literal>fillfactor</literal></link>. If you don't, <acronym>HOT</acronym> updates will still happen because new rows will naturally migrate to new pages and existing pages with sufficient free space for new row versions. The system view <link -- 2.37.0 ^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [PATCH] updates to docs about HOT updates for BRIN @ 2024-02-26 22:21 Stephen Frost <[email protected]> parent: Elizabeth Christensen <[email protected]> 0 siblings, 1 reply; 5+ messages in thread From: Stephen Frost @ 2024-02-26 22:21 UTC (permalink / raw) To: Elizabeth Christensen <[email protected]>; +Cc: [email protected] Greetings, * Elizabeth Christensen ([email protected]) wrote: > I have a small documentation patch to the HOT updates page > <https://www.postgresql.org/docs/current/storage-hot.html>to add references > to summary (BRIN) indexes not blocking HOT updates > <https://www.postgresql.org/message-id/[email protected]...;, > committed 19d8e2308b. Sounds good to me, though the attached patch didn't want to apply, and it isn't immediately clear to me why, but perhaps you could try saving the patch from a different editor and re-sending it? Thanks, Stephen Attachments: [application/pgp-signature] signature.asc (833B, ../../Zd0O8CqQM1ms%[email protected]/2-signature.asc) download ^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [PATCH] updates to docs about HOT updates for BRIN @ 2024-02-26 22:25 Elizabeth Christensen <[email protected]> parent: Stephen Frost <[email protected]> 0 siblings, 1 reply; 5+ messages in thread From: Elizabeth Christensen @ 2024-02-26 22:25 UTC (permalink / raw) To: Stephen Frost <[email protected]>; +Cc: [email protected] > On Feb 26, 2024, at 4:21 PM, Stephen Frost <[email protected]> wrote: > > Greetings, > > * Elizabeth Christensen ([email protected]) wrote: >> I have a small documentation patch to the HOT updates page >> <https://www.postgresql.org/docs/current/storage-hot.html>to add references >> to summary (BRIN) indexes not blocking HOT updates >> <https://www.postgresql.org/message-id/[email protected]...;, >> committed 19d8e2308b. > > Sounds good to me, though the attached patch didn't want to apply, and > it isn't immediately clear to me why, but perhaps you could try saving > the patch from a different editor and re-sending it? > > Thanks, > > Stephen Thanks Stephen, attempt #2 here. Elizabeth Attachments: [application/octet-stream] v2-0001-Adding-Summary-Index-Info-to-HOT-Update-Documentatio.patch (2.5K, ../../[email protected]/2-v2-0001-Adding-Summary-Index-Info-to-HOT-Update-Documentatio.patch) download | inline diff: From: elizabeth-christensen <[email protected]> Date: Mon, 26 Feb 2024 12:09:22 -0600 Subject: [PATCH] Adding Summary Index Info to HOT Update Documentation page Commit 19d8e2308b changed when the HOT update optimization is possible but neglected to update the Heap-Only Tuples (HOT) documentation. This patch updates that documentation accordingly. Author: Elizabeth Christensen Backpatch-through: 16 Discussion: --- doc/src/sgml/storage.sgml | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/doc/src/sgml/storage.sgml b/doc/src/sgml/storage.sgml index 3ea4e5526d..314469706e 100644 --- a/doc/src/sgml/storage.sgml +++ b/doc/src/sgml/storage.sgml @@ -1097,8 +1097,10 @@ data. Empty in ordinary tables.</entry> <itemizedlist> <listitem> <para> - The update does not modify any columns referenced by the table's - indexes, including expression and partial indexes. + The update only modifies columns which are un-indexed or are only indexed with + summarizing indexes (such as BRIN) and does not update any columns referenced + by the table's non-summary indexes, including expression and partial + non-summary indexes. </para> </listitem> <listitem> @@ -1114,7 +1116,8 @@ data. Empty in ordinary tables.</entry> <itemizedlist> <listitem> <para> - New index entries are not needed to represent updated rows. + New index entries are not needed to represent updated rows, however, + summary indexes may still need to be updated. </para> </listitem> <listitem> @@ -1130,11 +1133,10 @@ data. Empty in ordinary tables.</entry> </para> <para> - In summary, heap-only tuple updates can only be created - if columns used by indexes are not updated. You can - increase the likelihood of sufficient page space for - <acronym>HOT</acronym> updates by decreasing a table's <link - linkend="reloption-fillfactor"><literal>fillfactor</literal></link>. + In summary, heap-only tuple updates can only be created if columns used by + non-summary indexes are not updated. You can increase the likelihood of + sufficient page space for <acronym>HOT</acronym> updates by decreasing + a table's <link linkend="reloption-fillfactor"><literal>fillfactor</literal></link>. If you don't, <acronym>HOT</acronym> updates will still happen because new rows will naturally migrate to new pages and existing pages with sufficient free space for new row versions. The system view <link -- 2.37.0 ^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [PATCH] updates to docs about HOT updates for BRIN @ 2024-02-26 23:28 Stephen Frost <[email protected]> parent: Elizabeth Christensen <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Stephen Frost @ 2024-02-26 23:28 UTC (permalink / raw) To: Elizabeth Christensen <[email protected]>; +Cc: [email protected] Greetings, * Elizabeth Christensen ([email protected]) wrote: > > On Feb 26, 2024, at 4:21 PM, Stephen Frost <[email protected]> wrote: > > * Elizabeth Christensen ([email protected]) wrote: > >> I have a small documentation patch to the HOT updates page > >> <https://www.postgresql.org/docs/current/storage-hot.html>to add references > >> to summary (BRIN) indexes not blocking HOT updates > >> <https://www.postgresql.org/message-id/[email protected]...;, > >> committed 19d8e2308b. > > > > Sounds good to me, though the attached patch didn't want to apply, and > > it isn't immediately clear to me why, but perhaps you could try saving > > the patch from a different editor and re-sending it? > > Thanks Stephen, attempt #2 here. Here's an updated patch which tries to improve on the wording a bit by having it be a bit more consistent. Would certainly welcome feedback on it though, of course. This is a tricky bit of language to write and a complex optimization to explain. Thanks! Stephen Attachments: [text/x-diff] v3-0001-Adding-Summary-Index-Info-to-HOT-Update-Documentatio.patch (2.7K, ../../[email protected]/2-v3-0001-Adding-Summary-Index-Info-to-HOT-Update-Documentatio.patch) download | inline diff: From bb88237d1f807572a496ff2a267ab56bef61ac8e Mon Sep 17 00:00:00 2001 From: Stephen Frost <[email protected]> Date: Mon, 26 Feb 2024 17:17:54 -0500 Subject: [PATCH] docs: Update HOT update docs for 19d8e2308b Commit 19d8e2308b changed when the HOT update optimization is possible but neglected to update the Heap-Only Tuples (HOT) documentation. This patch updates that documentation accordingly. Author: Elizabeth Christensen Reviewed-By: Stephen Frost Backpatch-through: 16 Discussion: https://postgr.es/m/CABoUFXRjisr58Ct_3VsFEdQx+fJeQTWTdJnM7XAp=8MUbtoa9A@mail.gmail.com --- doc/src/sgml/storage.sgml | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/doc/src/sgml/storage.sgml b/doc/src/sgml/storage.sgml index 3ea4e5526d..d6c53a8d25 100644 --- a/doc/src/sgml/storage.sgml +++ b/doc/src/sgml/storage.sgml @@ -1097,8 +1097,11 @@ data. Empty in ordinary tables.</entry> <itemizedlist> <listitem> <para> - The update does not modify any columns referenced by the table's - indexes, including expression and partial indexes. + The update only modifies columns which are not referenced by the + table's indexes or are only referenced by summarizing indexes (such + as <acronym>BRIN</acronym>) and does not update any columns + referenced by the table's non-summarizing indexes, including + expression and partial non-summarizing indexes. </para> </listitem> <listitem> @@ -1114,7 +1117,8 @@ data. Empty in ordinary tables.</entry> <itemizedlist> <listitem> <para> - New index entries are not needed to represent updated rows. + New index entries are not needed to represent updated rows, however, + summary indexes may still need to be updated. </para> </listitem> <listitem> @@ -1130,11 +1134,10 @@ data. Empty in ordinary tables.</entry> </para> <para> - In summary, heap-only tuple updates can only be created - if columns used by indexes are not updated. You can - increase the likelihood of sufficient page space for - <acronym>HOT</acronym> updates by decreasing a table's <link - linkend="reloption-fillfactor"><literal>fillfactor</literal></link>. + In summary, heap-only tuple updates can only be created if columns used by + non-summarizing indexes are not updated. You can increase the likelihood of + sufficient page space for <acronym>HOT</acronym> updates by decreasing + a table's <link linkend="reloption-fillfactor"><literal>fillfactor</literal></link>. If you don't, <acronym>HOT</acronym> updates will still happen because new rows will naturally migrate to new pages and existing pages with sufficient free space for new row versions. The system view <link -- 2.34.1 [application/pgp-signature] signature.asc (833B, ../../[email protected]/3-signature.asc) download ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2024-02-26 23:28 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-03-12 21:35 [PATCH 06/10] Default to LZ4.. Justin Pryzby <[email protected]> 2024-02-26 20:29 [PATCH] updates to docs about HOT updates for BRIN Elizabeth Christensen <[email protected]> 2024-02-26 22:21 ` Re: [PATCH] updates to docs about HOT updates for BRIN Stephen Frost <[email protected]> 2024-02-26 22:25 ` Re: [PATCH] updates to docs about HOT updates for BRIN Elizabeth Christensen <[email protected]> 2024-02-26 23:28 ` Re: [PATCH] updates to docs about HOT updates for BRIN Stephen Frost <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox