Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 26 Feb 2024 08:37:20 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Alexander Pyhalov <a.pyhalov@postgrespro.ru>,
	Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: ExecAppendAsyncEventWait() in REL_14_STABLE can corrupt
 PG_exception_stack
Message-ID: <ZdvPMIvz90dfQ4ws@paquier.xyz>
References: <425fa29a429b21b0332737c42a4fdc70@postgrespro.ru>
 <ZdlBFS25eKruiQvO@paquier.xyz>
 <CAPmGK17=Asbxv5Bka3SC==yG1q+1MGV9LA6sb_DqLUG7AxbBAQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="EtfEpGyw4bN55VEF"
Content-Disposition: inline
In-Reply-To: 
 <CAPmGK17=Asbxv5Bka3SC==yG1q+1MGV9LA6sb_DqLUG7AxbBAQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZdvPMIvz90dfQ4ws%40paquier.xyz>
Precedence: bulk


--EtfEpGyw4bN55VEF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Feb 25, 2024 at 06:34:30PM +0900, Etsuro Fujita wrote:
> I think this would happen when FDWs configure no events; IIRC I think
> while the core allows them to do so, postgres_fdw does not do so, so
> this would never happen with it.  Anyway, thanks for the report and
> patch, Alexander!

I don't see how that's directly your fault as this is a thinko in the
set of commits 481d7d1c01, 555276f859 and 501cfd07da that have hit
14~16, ignoring entirely the TRY/CATCH block.

Anyway, if you want to address it yourself, feel free to go ahead,
thanks!  I would have done it but I've been busy with life stuff for
the last couple of days.
--
Michael

--EtfEpGyw4bN55VEF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmXbzzAACgkQnvQgOdby
QH1zBhAAjW8vgDh6N+mEyshSNugBBGyV45Ia6uwHNH3fXnvI2IPG8dKj5dZlKswa
784fbPyowNnMKQFwzXUfxx53Ylms/0LfFqfnyCvqWoGW4K3nkmbqNQpUzTIgQ04C
MtTCTrKUNY3SYHMzd2tu1Pu33z1J9te+ltW4KOwbvURUN56mobuwH+J4ZVXCY/Bq
iPC4MuMBlukGbEwwKv+CH5Wu/aP7pqiXVr+sh9CpUoLuY4WkKffTCwKf8pXbG07F
i9mq3CXtv8OU84nwGNc79LPEfvvCRrdLrxy1/mciPry0YpCopjIvkeC6h6ja2lDk
Qi7URq4AdnPyyMuSz4rKyReSI3ZvcQjRCm91Cu1p89/72RIC5lJpmEUBejOjWAnH
1gPwK3o3MACTm70trTsqxgYL1kEP3bIaWzxrWGDegi3Qnzy0oeTBJZgv/83yWpgU
xFKeoYDLNkRkMJTBjJsIooAEen2BVOTCabc7T+eSDbNHgPeTcWoexGJ+SQ4tfZSw
Ioy5ZT4MSOHJOUQVextKj/GWeWeuiDEwUjYV4L6h/X9KYiDQB1KTN86Cpq5T8CIa
DS5o442S1uNPPsqd8e88PrTxjdlSKaLDpLCT8zVpzFtddrAHf1vHHvXuXs0c0dTc
BlknvPUag6INCuJq9CBGIdCXmOiyroJLoedNAtOLjTr+y5YUaOI=
=VJwO
-----END PGP SIGNATURE-----

--EtfEpGyw4bN55VEF--