Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1reW4v-00BljO-Dg for pgsql-hackers@arkaria.postgresql.org; Mon, 26 Feb 2024 08:11:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1reW4t-00Bdfy-7r for pgsql-hackers@arkaria.postgresql.org; Mon, 26 Feb 2024 08:11:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1reW4r-00Bdfp-Hw for pgsql-hackers@lists.postgresql.org; Mon, 26 Feb 2024 08:11:11 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1reW4k-0018Bg-NT for pgsql-hackers@lists.postgresql.org; Mon, 26 Feb 2024 08:11:08 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 870903200A59; Mon, 26 Feb 2024 03:11:01 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 26 Feb 2024 03:11:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1708935061; x=1709021461; bh=df4SQyF5dz J7rk30n+0tQ32x3uy51OAdSI+LY+vCe8U=; b=FnPkRFgAYpr+zQkr85EbQNSfI/ 3DnGcQtICQQdyLtxefWI2nEKcne8/6Dt4vQtTdGrafolRWjr7oiKYHmzXq0dXF93 xTdYGaY4qEdlvO9w7dnWz7TbqJwC6KvOoLrhwxzAAs+OVRP+lv59Z96KaRKUV1LB Wo+LtzJcKM74kizkIs/EpW0eEe6LPlFL6XOOcXXC0DCXtzV8ok2OM50G+XmmPX+k VU9ym0NvAJUgEkTI2XHZ6aXbguX+MiLDNtWkk1FdDodA75R816vnW/hqXY8BsXUh m0O2MEdmQM20dDPfkMtQwTvmOMP+rBq6nooddVgWn92sZJGWCxKjVMzr055Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1708935061; x=1709021461; bh=df4SQyF5dzJ7rk30n+0tQ32x3uy5 1OAdSI+LY+vCe8U=; b=BBDEDtN896EH3alII/5DEP2tX01ww4uNvA4Szgk3hCWT bKn1dvNlOAql2BpuFoXlXYGUApmbF5NPUhOx8SrbJUbztpcwk/SnZC7KpSONVlnt AoOVWt7xph/5yd0bUqxtgypAh/He1OsgYH/mnSB15NNk2pU5ciZLuX0ewfnF/JTZ 0KIsnuM7HDnC/mq3WVdm+ifBIq1tAiadwskITrL8pUJaZSvRjCz0Y2ieJrIYTZfg A7VFY0ht9Ikzek66WAXJwyIFjW6HWZnh/iwjeaEwdy9ZPYa8Pr7jThXhvGaUNyoZ Z69fxlm+zsRBFJkIppnULouXWbKbAQSiN0Jojvsnxg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrgedugdduudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Feb 2024 03:10:58 -0500 (EST) Date: Mon, 26 Feb 2024 17:10:45 +0900 From: Michael Paquier To: Tomas Vondra Cc: Peter Smith , Postgres hackers Subject: Re: Sequence Access Methods, round two Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="J/PQROqXM4LhuX+Y" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --J/PQROqXM4LhuX+Y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 22, 2024 at 05:36:00PM +0100, Tomas Vondra wrote: > 0002, 0003 > ------------ > seems fine, cosmetic changes Thanks, I've applied these two for now. I'll reply to the rest tomorrow or so. By the way, I am really wondering if the update of elm->increment in nextval_internal() should be treated as a bug? In the "fetch" cache if a sequence does not use cycle, we may fail when reaching the upper or lower bound for respectively an ascending or descending sequence, while still keeping what could be an incorrect value if values are cached on a follow-up nextval_internal call? -- Michael --J/PQROqXM4LhuX+Y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmXcR4UACgkQnvQgOdby QH1P/A/+OjQGpBc4fjeypbfn0hmnqahfwZ6fRz+slcbP21nVFHIJKJ2P1qnloSXK Yw3iVinkB8qjF82sMwNtPr2cEjki4qqqiE2t9ftZAw47/lxXN0fOR36alp77w6It cbY6oSugsjVqJnm5BhFiAfnOVyPVwVirn4Ui947cuPutYp6/axTL9x2RHmam4gCU 7VhbdJrl+lJWRp7KIR+Q+lj6/WVg7U6rLtqTkxB26gPPMbt5EErcTb12qe5ld1+d eJuKZIfITL/YQcYvslcjho504W4ClDHoXQgL1UR1dfxrLC+3u5B02hQ4LVON8HYX utdQbNENqpP2mYibF6M9bQ07kPYgFYD8a7pNl9kamQ9gi9HaBL72bYNhRpDLYhOl 4wruIsnOon50i17lnpbIf/QJRY6qd4feiMTWJg9LejRjtmF0pjYptCACxsphTkHf AZH6C7NVR7vNLVTBBSVtojxHUUXvDTFGha9BkDksy4vyrNNKMlepGb84a64clgUz tLxBBkJ8UXULOXwjNP9ExsiqxCOcyQsTKFiyF24iMwBLFFjRL1GJ2d7YYE410Wv3 aq/93KCi/AN8fP7ltkgNo3K7mlXEULenj5AuENtULSpuLqx/zMmFoBKEtKT5wFRg EV2tyC3KJRuSwCJ4Yvq28p3ymENCbGzJrRPlbX29U3mwELUhhw8= =fkdR -----END PGP SIGNATURE----- --J/PQROqXM4LhuX+Y--