Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 12 Mar 2024 08:44:34 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Peter Smith <smithpb2250@gmail.com>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Sequence Access Methods, round two
Message-ID: <Ze-XYr9lbBS9Naq8@paquier.xyz>
References: <ZWlohtKAs0uVVpZ3@paquier.xyz>
 <ZXK9ckwMCiPBTBNK@paquier.xyz>
 <CAHut+Ps27m0bCmmPYNXC282phpm1vkS+_kmHRR=mKHDuJd0C9Q@mail.gmail.com>
 <Za4Lm8veCea-rsUU@paquier.xyz>
 <ef7114ee-e629-4132-b92d-d9104e2a40d7@enterprisedb.com>
 <Zd06cdyl0sqPrrVC@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="WaX2JM8tk/3HeI39"
Content-Disposition: inline
In-Reply-To: <Zd06cdyl0sqPrrVC@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/Ze-XYr9lbBS9Naq8%40paquier.xyz>
Precedence: bulk


--WaX2JM8tk/3HeI39
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 27, 2024 at 10:27:13AM +0900, Michael Paquier wrote:
> On Thu, Feb 22, 2024 at 05:36:00PM +0100, Tomas Vondra wrote:
>> 0001
>> ------
>>=20
>> I think this bit in pg_proc.dat is not quite right:
>>=20
>>   proallargtypes =3D> '{regclass,bool,int8}', proargmodes =3D> '{i,o,o}',
>>   proargnames =3D> '{seqname,is_called,last_value}',
>>=20
>> the first argument should not be "seqname" but rather "seqid".
>=20
> Ah, right.  There are not many system functions that use regclass as
> arguments, but the existing ones refer more to IDs, not names.

This patch set is not going to be merged for this release, so I am
going to move it to the next commit fest to continue the discussion in
v18~.

Anyway, there is one piece of this patch set that I think has a lot of
value outside of the discussion with access methods, which is to
redesign pg_sequence_last_value so as it returns a (last_value,
is_called) tuple rather than a (last_value).  This has the benefit of
switching pg_dump to use this function rather than relying on a scan
of the heap table used by a sequence to retrieve the state of a
sequence dumped.  This is the main diff:
-    appendPQExpBuffer(query,
-                      "SELECT last_value, is_called FROM %s",
-                      fmtQualifiedDumpable(tbinfo));
+    /*
+     * In versions 17 and up, pg_sequence_last_value() has been switched to
+     * return a tuple with last_value and is_called.
+     */
+    if (fout->remoteVersion >=3D 170000)
+        appendPQExpBuffer(query,
+                          "SELECT last_value, is_called "
+                          "FROM pg_sequence_last_value('%s')",
+                          fmtQualifiedDumpable(tbinfo));
+    else
+        appendPQExpBuffer(query,
+                          "SELECT last_value, is_called FROM %s",
+                          fmtQualifiedDumpable(tbinfo));

Are there any objections to that?  pg_sequence_last_value() is
something that we've only been relying on internally for the catalog=20
pg_sequences.
--
Michael

--WaX2JM8tk/3HeI39
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmXvl2IACgkQnvQgOdby
QH2SrRAAg7cnkVe13IZky0rwdO7yHwXQ/WNefOxnny5aHO7bwit1nklw24nZeyCD
dGfMhVG0uTbcIwGLCGWx1HDmRy+ubJxfWwe5Iq6tiHciY9W0TEe3R5WCkBV6yBnt
sgX13i0pB75eklfTdyqieYuDXhEZK9NjRKTG7R115Vzj/1rOMz0fCqc7XzuwXHe5
r71tM/dtbFg3wzJ+wdkdtfl67Y3xwcgEt3JbANKpx2TBLGJfS0SmXvmvA6U1O+2p
5WQuI78sA1QFdS7eTspNn1UaD9anwZvLqIjm6Gi8qvk0ImGvNoEpauGGf2u3+xR6
R3G0Reo5ozT7WU67aWHuechm3cHs0bp6nVGEq5UK4bHXH6gLGW/QqH46GuNVgws8
QGew1PADYc24exYqieqdbGU9PzYxtU0bFId4K10nGL09NfO8mqU3G2BjkpJV/knS
EjvAKWN3jOE3YLOAoUzBW4DkPO1/T4jw4flTR/WHS1kwsRF7wg5NfTfNLh9WTULb
IFRwju9sxUHdtDkGx2lcHedLVtphbNdyZ+eocLutVzKogMSqDquklgv8pObWTuWc
4lfauhMcHV4WPA3Gbht8xj3omifXZKf+tg/1SbgHSZkrnuZ/CFvSdyuWxKkxpgzv
0k4YC8Qv+0t3I6N528yMXlZEwpOneVd0+fO7Wm0T00djTX4HBFg=
=h/hH
-----END PGP SIGNATURE-----

--WaX2JM8tk/3HeI39--