Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rfsHV-002qlX-5C for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Mar 2024 02:05:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rfsHS-00AP0Z-RM for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Mar 2024 02:05:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rfsHS-00AP0R-IP for pgsql-hackers@lists.postgresql.org; Fri, 01 Mar 2024 02:05:47 +0000 Received: from fhigh4-smtp.messagingengine.com ([103.168.172.155]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rfsHM-002BIO-6Z for pgsql-hackers@lists.postgresql.org; Fri, 01 Mar 2024 02:05:46 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 623C6114013A; Thu, 29 Feb 2024 21:05:38 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 29 Feb 2024 21:05:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1709258738; x=1709345138; bh=xdFz4Fqo0q tgp8UG5vBhsctacT/TM1Y1HDKtm2SEJhM=; b=jgz2YRLM/qDlaCdEFfsBzQ0N0j WcwnzKJbpjvPGji+BUeUSS0VpXhadKt4yCif0PVORfOg6v0aKOWVxysvKyWE+/uC dGteDVbVuadwwLB0E3uhWZDlYZZvh5l1Q1XrScbN/OTxixP4ohPy8Bq8Rl1ojvVH TxUXoR/SJzokR4kUPYnDLfYDlJYYT/rnt+osRNbqs58FnfwWF0B7YD3WDkIa5AgQ lxWnNAmXjolKailxRacNhwzSARYHnf4D8RSwo3TOPXK8cj0DELbb8deCo4SuzwqS mjLR3gP4RAzHW3yYijXGYd69mQ+usTrICq8Bf88SajC1q0guhSf/s8cVuqqg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1709258738; x=1709345138; bh=xdFz4Fqo0qtgp8UG5vBhsctacT/T M1Y1HDKtm2SEJhM=; b=a/z1++0MiCuCnH6X4HoL7GgkiDjPm+1i4ig5YXR3gdk0 uUo9kvElxjgJIiiy7/gTdLGl5Vu0kSbT7SBdkCUEMAgtg9mwuJpFYLFdb0Sa8DzT NYtctz595ci1j7GhA7JSpKXlNUbl2gycuFFHoxi3kwTwy+wU9w/hlLr9yfnPdm/A kXNd1JOuAQ7qhpF1cyTxlP3vRKIOZVq0LeW8a+fcYqudUTHdQrYVHl7yIw1hLx4J kjdaY6/2VZih2oJca7qczCvRyEubyj3WwOANb/gB3K2yXIfy/aauDqPoi9Qj+tRI A1F7ASyir/Fgw50Zq4V7DgHO4mdoloz1KERNBgnGVw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrhedtgdeflecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeg geffhfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Feb 2024 21:05:37 -0500 (EST) Date: Fri, 1 Mar 2024 11:05:27 +0900 From: Michael Paquier To: jian he Cc: Postgres hackers Subject: Re: Propagate sanity checks of ProcessUtility() to standard_ProcessUtility()? Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ddVYAcAlTPZzs29c" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --ddVYAcAlTPZzs29c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 29, 2024 at 04:10:26PM +0800, jian he wrote: > why not just shovel these to standard_ProcessUtility. > so ProcessUtility will looking consistent with (in format) > * ExecutorStart() > * ExecutorRun() > * ExecutorFinish() > * ExecutorEnd() That's one of the points of the change: checking that only in standard_ProcessUtility() may not be sufficient for utility hooks that don't call standard_ProcessUtility(), so you'd stil want one in ProcessUtility(). -- Michael --ddVYAcAlTPZzs29c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmXhN+cACgkQnvQgOdby QH0sUQ/+P3kSYz+akiryFpYpP5ZQkzAzflozS+KFd/ymTcwxCbvXgwMgT3Emg570 hpyRGJepotr9xZz10vZI0TzZMfDyOFbKNAEJlr6601OSSD07IZuOr+JjzeK8uAq4 OE+QChI0GcNXk0f/lJS43yI7IHTHWI/uBfFE9cov/AIyaVdfKBikquCo5GN5ItcD GIv4x8HWmJcqQfTSHjyI54WxM57QDvyteY+L3hvWPcPtVtxSc+L2hRM0cYh8KrZk hCnhD259pfH6CwQuJPA7xoyM0KZvBq/2GlKqqtbtr+OuExjSZ3swg6urB8MCZ83I nxigBJtQ3VwsBVpyNsUos4TIZ0InMpPN9DQFLU+sZXEDrm8KFSSKrK9G2pctppbZ XlRKhhOsuJAvaO1KDWX8scFITcNnERLH4AfmGeOzpBvHFukxQ67+36gMj5SHSCaQ /Ozy32lAHqgAUL8u1i3U1IfDzO7Hk9e0+jmeAvt+qu/F4l11SamQ/rUJsKgw07iE 3sL6XGm+Sri8xvMGCC+IvQBAGyvz6iFhJC2saCFVx9KvaoUBA99l58v+tS4Inm5S xxSstnXj2iTeeJxjzBYT70Gtp8xbwtye9JQl6LEfrC1lDHtP7rMkvLQSp3D/0iVB 7HanBHvGb9G84oqrPL8QqVe8QP+ZCTolihjxWew4AXHAlb0L4S0= =OH3E -----END PGP SIGNATURE----- --ddVYAcAlTPZzs29c--