Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 1 Mar 2024 14:58:37 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Amul Sul <sulamul@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Add system identifier to backup manifest
Message-ID: <ZeFujZcC7kPI9WzP@paquier.xyz>
References: <CAAJ_b9417seAdhwhMVr=PnQ+MPx7uAeS5FAw2qMCXF5MrE-7wQ@mail.gmail.com>
 <CA+Tgmoa78r+U-X2EoGrvNDuKur5MhMtvZbm01-c1ziRgSq9MEA@mail.gmail.com>
 <CAAJ_b97pp0=xXwW=VKWTxKDF2r7uYXYxZnTggF6dRHtnjwi+WA@mail.gmail.com>
 <CA+Tgmoa8okr1YCFcCOGgvOTASiXsJgx-oqrCS41Wir=oC8c-mA@mail.gmail.com>
 <CAAJ_b95tfUo9CyCX-=0V1L=VNzzvcf4dGLT6ae7=kz2ELy2Edg@mail.gmail.com>
 <Zc1tX9lLonLGu6oH@paquier.xyz>
 <CAAJ_b961KftvFLJYvJ1-CWk13dLVcb0+o=q0BRd3n8NJ-ceWBQ@mail.gmail.com>
 <CA+TgmoYrs8A2j-4KhkjtKp6MwJRwOkXHdXVg4DE6nDOMgDBxMA@mail.gmail.com>
 <ZdKKFfM4_HQmbDpE@paquier.xyz>
 <CAAJ_b97_9nJCD3kAmNfSnN1s7m9n1h97OP=APwts=g-rWGztxQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="a/u1cdFRDmUDb4Oj"
Content-Disposition: inline
In-Reply-To: <CAAJ_b97_9nJCD3kAmNfSnN1s7m9n1h97OP=APwts=g-rWGztxQ@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZeFujZcC7kPI9WzP%40paquier.xyz>
Precedence: bulk


--a/u1cdFRDmUDb4Oj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 19, 2024 at 12:06:19PM +0530, Amul Sul wrote:
> Agreed, now they will have an error as _could not read file "<DataDir>": Is
> a directory_. But, IIUC, that what usually happens with the dev version, and
> the extension needs to be updated for compatibility with the newer version for
> the same reason.

I was reading through the remaining pieces of the patch set, and are
you sure that there is a need for 0002 at all?  The only reason why
get_dir_controlfile() is introduced is to be able to get the contents
of a control file with a full path to it, and not a data folder.  Now,
if I look closely, with 0002~0004 applied, the only two callers of
get_controlfile() are pg_combinebackup.c and pg_verifybackup.c.  Both
of them have an access to the backup directories, which point to the
root of the data folder.  pg_combinebackup can continue to use
backup_dirs[i].  pg_verifybackup has an access to the backup directory
in the context data, if I'm reading this right, so you could just use
that in verify_system_identifier().
--
Michael

--a/u1cdFRDmUDb4Oj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmXhbo0ACgkQnvQgOdby
QH1mww/+OkM2TsE4CPcEgmv5I0aABZpNYIKIigCxgbp1/gY1nLJYecNFSct96m1L
eK9Q4jL+ChfVB7zbtZOPJixoCLWPX9rfGokhT0uQcCon5bEuqJafBq9s3lge7tYb
lJMXjlnCbPtqs71cJsFN5D7Rc6zVLGozgdRjtYQ27zuZSF8yQ1gUJ5yvZBnMVpRt
N+tOpBgZqTuzP+7bm44uZQrUv3gJA3NS40temN/ReyaTgTYpA5/iV5WUOmXALP7e
VzmdVu7Mu74v+OmpXM1l6QgHyQepBnIY1M9RJp9p5O0+YHC3wXgy9DuBh7yV2hLr
hcfwwmXyUdqSEhDHhKldpFukk3IX7gOPv9H+dloH86soiaCltS3jGXM9v/dwexNw
3wFw4XGkVo/3rv3aanm4/yVmDU6g9kBk02+cleWQ7zgUSdtnOKQ+M1cIeUaoljir
SOAkIbt/qL1p23cG+FF6jqHcJgA1dikEf1q5RzRv6ZMToOGn/OnHFD3u5zpjCNxn
gZZQLJsOruBQ1vBOVN27he8FJfDv4JDZ/zytGKBO/txgru1njyobIN6OcaEys+fB
gbEXcvn/DdQ164QHeEG1jmj/G2SLwyK/4hr255YTIDI1wO6RyCYU0yp/Kk7ZvhAV
HrMH9o45ytyD0TrJHAO9R8RXmJNuGoy6p6V49/wPiHDcL5fY2yE=
=r4m4
-----END PGP SIGNATURE-----

--a/u1cdFRDmUDb4Oj--