Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 4 Mar 2024 14:27:22 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	"Andrey M. Borodin" <x4mmm@yandex-team.ru>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>,
	Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Subject: Re: Injection points: some tools to wait and wake
Message-ID: <ZeVbugAp1eXCvllA@paquier.xyz>
References: <Zd7Quc2JXdUg2tar@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZeAch9AYrH7UGlCn@paquier.xyz>
 <ZeBB4RMPEZ06TcdY@ip-10-97-1-34.eu-west-3.compute.internal>
 <9F7DF199-11E0-47D3-B7AE-379EFC6109C2@yandex-team.ru>
 <ZeBaXWgYZRkOVY1m@ip-10-97-1-34.eu-west-3.compute.internal>
 <BA18A010-60B4-4FAA-AC56-AC95793A5A04@yandex-team.ru>
 <ZeE3GTbamjlN1RrP@paquier.xyz>
 <ZeF7Pct9eJaN6z5N@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZeUngiC5Wzi_LiYH@paquier.xyz>
 <CAGECzQQB0YwoCo8za5DSs1zNyMPHLiz5jwOi-xRhe5517qNugA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="F+gcYZhoxFcSEyE9"
Content-Disposition: inline
In-Reply-To: 
 <CAGECzQQB0YwoCo8za5DSs1zNyMPHLiz5jwOi-xRhe5517qNugA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZeVbugAp1eXCvllA%40paquier.xyz>
Precedence: bulk


--F+gcYZhoxFcSEyE9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Mar 04, 2024 at 05:17:52AM +0100, Jelte Fennema-Nio wrote:
> I noticed this was committed, and took a quick look. It sounds very
> useful for testing Citus to be able to use injection points too, but I
> noticed this code is included in src/test/modules. It sounds like that
> location will make it somewhat hard to install. If that's indeed the
> case, would it be possible to move it to contrib instead?

One problem with installing that in contrib/ is that it would require
more maintenance as a stable and "released" module.  The aim of this
module is to be more flexible than that, so as it is possible to
extend it at will even in the back branches to be able to implement
features that could help with tests that we'd want to implement in
stable branches.  I have mentioned that on a separate thread, but
adding more extension maintenance burden while implementing complex
tests does not sound like a good idea for me in the long-run.

Perhaps we could consider that as an exception in "contrib", or have a
separate path for test modules we're OK to install (the calls had
better be superuser-only if we do that).  Another thing with the
backend support of injection points is that you could implement your
own extension within citus, able to do what you mimic this in-core
module, and get inspiration from it.  Duplication is never cool, I
agree, though.
--
Michael

--F+gcYZhoxFcSEyE9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmXlW7kACgkQnvQgOdby
QH2/8A/9EfVlmXBQDcH7eyJg2j4ihZwhwnr6jiAAud2Hj1AxpagBo1fDyebsPKYZ
nLDAUbm8Q5WOZabiIrBASmNAiSP+oNtvTMWrF2qCbZINIiN7vE1kpJgta3HIP7F/
DHY+1Ajo2rGWxZ2silgkWGUQTWhD8M15ugU2OABr3J16C8bx5kM3hK9fCrlvsjbw
Y4jsFhyKCX3adv89LHD4dB1aO8go8mP3COadSxqUAcZd7qW+aQJQCj9SdUyToS2D
+ZtJwdooB+n2rvz5FOpJmZyWDAXQ/Ap6thGB/QW7gPu/NkiDj504Uq3x49EpF9mR
CTcNkmnFeyOvvD/dRv9E4hn0bLyDL+Lr/KZfjb93CNSXkBMTIKDN7S5cssgVMq/b
ax4H/9VfQWJI+Pgn4FDMihvQ+v3owxZWyVtxRHd/IxkvWXmy67V6QCxKe5szgmHg
uRxRPsJljddDunoiNn15PY1B6OjQP9IUR68ZMQkRGVlJ846xmjseC6tUOQ8yljZx
rRSy9tUOmMAJKE4JN9gcj9n3U5k6Kmbf5o1/fmPyyrEDyudKM0WNUGELUZRajmMP
+Logk4g1ccpVO6+bFT+YThO9pjvyWRTsafjPIIbMGnjCsAm1k2p4IA7FikJ1fkPl
8awLuQ4Kd8kFYOmivS41xwkZgZcZjYkphko22hzpc9/AI44sYkM=
=8dI8
-----END PGP SIGNATURE-----

--F+gcYZhoxFcSEyE9--